From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 00/14][RESEND] STK patches without agent
Date: Thu, 15 Jul 2010 15:46:34 -0500 [thread overview]
Message-ID: <4C3F73AA.7080603@gmail.com> (raw)
In-Reply-To: <AANLkTilVBUkiZnL6OXgkdZMGIflA4uhrnMH89uHzgZkh@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 747 bytes --]
Hi Andrew,
>> All patches in this series have been pushed upstream with some
>> refactoring afterwards. Please review and make sure I didn't screw
>> something up.
>
> Thanks, just a small change to remove the seconds == 0 check for Set
> Poll Interval. Seconds can't be 0 or parsing would fail. The logic
> behind the original code was:
>
> Try to set the modem property to "seconds".
> If setting fails, then return the previous value (which is actually
> the nearest value we could accept).
> If getting previous value fails (function returns 0) then return 30
> secs, the default value, which also happens to be the nearest we could
> accept.
>
Thanks for catching this. Patch has been applied.
Regards,
-Denis
prev parent reply other threads:[~2010-07-15 20:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-06 22:38 [PATCH 00/14][RESEND] STK patches without agent Andrzej Zaborowski
2010-07-06 22:38 ` [PATCH 01/14] stk: Utilities for proactive command/envelope handling Andrzej Zaborowski
2010-07-06 22:38 ` [PATCH 02/14] mbmmodem: End session on *STKEND Andrzej Zaborowski
2010-07-06 22:38 ` [PATCH 03/14] stk: Handle the More Time proactive command as a nop Andrzej Zaborowski
2010-07-06 22:38 ` [PATCH 04/14] Add OFONO_ERROR_TYPE_SIM for negative SIM statuses Andrzej Zaborowski
2010-07-06 22:39 ` [PATCH 05/14] atmodem: Make sim operations return sim error codes Andrzej Zaborowski
2010-07-06 22:39 ` [PATCH 06/14] stk: Handle ENVELOPEs in a queue, retry on sim busy Andrzej Zaborowski
2010-07-06 22:39 ` [PATCH 07/14] Add __ofono_sms_submit for other atoms to submit SMs Andrzej Zaborowski
2010-07-06 22:39 ` [PATCH 08/14] stk: Handle the Send SMS proactive command Andrzej Zaborowski
2010-07-06 22:39 ` [PATCH 09/14] Add Dbus interface names for STK Andrzej Zaborowski
2010-07-06 22:39 ` [PATCH 10/14] stk: Handle the Set Up Idle Text proactive command Andrzej Zaborowski
2010-07-06 22:39 ` [PATCH 11/14] sktutil: Use the Mandatory flag in parse_dataobj Andrzej Zaborowski
2010-07-06 22:39 ` [PATCH 12/14] stkutil: Timer Value is conditional, not optional Andrzej Zaborowski
2010-07-06 22:39 ` [PATCH 13/14] stk: Handle the Timer Management proactive command Andrzej Zaborowski
2010-07-06 22:39 ` [PATCH 14/14] stk: Handle the Poll Interval " Andrzej Zaborowski
2010-07-08 19:28 ` [PATCH 00/14][RESEND] STK patches without agent Denis Kenzior
2010-07-15 20:37 ` Andrzej Zaborowski
2010-07-15 20:46 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3F73AA.7080603@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox