From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 4/4] make bluetooth.{c,h} a static library
Date: Sun, 18 Jul 2010 20:39:18 -0500 [thread overview]
Message-ID: <4C43ACC6.9030307@gmail.com> (raw)
In-Reply-To: <1279496050.4572.16.camel@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 1162 bytes --]
Hi Marcel,
>> Ok, so I'll wait to continue my implementation of the DUN client. I
>> don't know the oFono internal too much to help on that decision.
>
> I was talking about the server and not the client. For the client we
> have to have a chat about it. I might have missed parts of the initial
> discussion.
>
As we discussed before, the client needs settings strings to send to the
modem. E.g. AT+CGDCONT=foobar; ATD*99***1. oFono atoms are not setup
to do this.
>>> Also there is no need to create a static library for doing this. That is
>>> just wrong. We can do the build magic with autofoo properly and without
>>> having to use a hack with a static library.
>>
>> I meant build statically here like gatchat, without any hack with static
>> library. ;)
>
> Actually gatchat is not build statically. It is build as part of out AT
> modem driver. That it is in separate directory is purely cosmetic.
>
GAtChat will end up used by the core for the ppp integration. I argued
that bluetooth should follow the same semantic, since it will be used by
both dun client daemon and oFono hfp/sap plugins.
Regards,
-Denis
prev parent reply other threads:[~2010-07-19 1:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-18 22:57 [PATCH 1/4] remove log to make bluetooth.c a static library Gustavo F. Padovan
2010-07-18 22:57 ` [PATCH 2/4] bluetooth: move uuid to struct bluetooth_profile Gustavo F. Padovan
2010-07-18 22:57 ` [PATCH 3/4] bluetooth: do not use ofono_dbus_get_connection Gustavo F. Padovan
2010-07-18 22:57 ` [PATCH 4/4] make bluetooth.{c,h} a static library Gustavo F. Padovan
2010-07-18 23:01 ` Marcel Holtmann
2010-07-18 23:05 ` Gustavo F. Padovan
2010-07-18 23:10 ` Marcel Holtmann
2010-07-18 23:23 ` Gustavo F. Padovan
2010-07-18 23:34 ` Marcel Holtmann
2010-07-19 1:39 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C43ACC6.9030307@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox