Open Source Telephony
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 2/4] Add original patch format checking script
Date: Mon, 19 Jul 2010 12:50:12 -0500	[thread overview]
Message-ID: <4C449054.3010509@gmail.com> (raw)
In-Reply-To: <1279520369-13214-2-git-send-email-yang.gu@intel.com>

[-- Attachment #1: Type: text/plain, Size: 749 bytes --]

On 07/19/2010 01:19 AM, Yang Gu wrote:
> This test script is just a copy from kernel project. oFono uses this one
> to check if the patch has some coding style issue.
> ---
>  test/checkpatch.pl | 2615 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 2615 insertions(+), 0 deletions(-)
>  create mode 100755 test/checkpatch.pl
> 

I'm a bit hesitant to include this in oFono tree. I have zero Perl
knowledge and I want to keep it this way ;)

If someone someone commits to maintaining checkpatch.pl and making sure
all changes are synced with the kernel upstream version then I can
re-consider.  Perhaps a simpler script that uses
/usr/src/linux/checkpatch.pl might be easier to maintain?

Regards,
-Denis

  reply	other threads:[~2010-07-19 17:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-19  6:19 [PATCH 1/4] Add coding style document Yang Gu
2010-07-19  6:19 ` [PATCH 2/4] Add original patch format checking script Yang Gu
2010-07-19 17:50   ` Denis Kenzior [this message]
2010-07-19  6:19 ` [PATCH 3/4] Add git commit header and description check Yang Gu
2010-07-19  6:19 ` [PATCH 4/4] Dont check Signed-off-by by default Yang Gu
2010-07-19 17:45 ` [PATCH 1/4] Add coding style document Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C449054.3010509@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox