From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 2/5] stk: Add menu related utilities.
Date: Fri, 23 Jul 2010 14:10:48 -0500 [thread overview]
Message-ID: <4C49E938.2030509@gmail.com> (raw)
In-Reply-To: <1279798973-6612-2-git-send-email-andrew.zaborowski@intel.com>
[-- Attachment #1: Type: text/plain, Size: 562 bytes --]
Hi Andrew,
> +static struct stk_menu *stk_menu_create(const char *title,
> + const struct stk_text_attribute *title_attr, GSList *items,
> + const struct stk_item_text_attribute_list *item_attrs,
> + const struct stk_items_next_action_indicator *next_action,
> + int default_id, gboolean soft_key, gboolean has_help)
> +{
I suggest breaking up this giant constructor with many arguments into
two functions. One that takes a setup_menu object and one that takes a
select_item object. Then fills in the items appropriately.
Regards,
-Denis
next prev parent reply other threads:[~2010-07-23 19:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-22 11:42 [PATCH 1/5] stk: Add agent registration and logic Andrzej Zaborowski
2010-07-22 11:42 ` [PATCH 2/5] stk: Add menu related utilities Andrzej Zaborowski
2010-07-23 19:10 ` Denis Kenzior [this message]
2010-07-22 11:42 ` [PATCH 3/5] stk: Handle the main menu Andrzej Zaborowski
2010-07-22 11:42 ` [PATCH 4/5] stk: Handle the Select Item proactive command Andrzej Zaborowski
2010-07-22 11:42 ` [PATCH 5/5] stk: Handle the Display Text " Andrzej Zaborowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C49E938.2030509@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox