From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 2/2] huawei: postpone post_sim until SIM is ready
Date: Fri, 13 Aug 2010 10:38:45 -0500 [thread overview]
Message-ID: <4C656705.1030902@gmail.com> (raw)
In-Reply-To: <87eie353p2.fsf@potku.valot.fi>
[-- Attachment #1: Type: text/plain, Size: 1107 bytes --]
Hi Kalle,
On 08/13/2010 03:15 AM, Kalle Valo wrote:
> Hi Denis,
>
> Denis Kenzior <denkenz@gmail.com> writes:
>
>> So this problem affects multiple modem families and I think we should
>> solve it a bit better. What I'm proposing is to introduce a new
>> function to include/sim.h. Something like:
>>
>> void ofono_sim_ready_notify(struct ofono_sim *sim);
>>
>> The way it should work is as follows:
>>
>> When oFono determines the SIM PIN is READY, it checks whether
>> ofono_sim_ready_notify has been called. If it hasn't, then it stalls
>> the initialization procedure (and calling post_sim) until
>> ofono_sim_ready_notify is called.
>>
>> This way if the SIM is not PIN locked, the driver can call sim_inserted
>> and sim_ready at once. If the PIN is locked, the driver can notify
>> sim_ready later.
>
> Sounds good to me. Do you want to implement it? ;) I'm a bit busy right
> now and it might take some time before I can find time for this.
>
I'm a bit swamped at the moment. I have added a TODO task for this
feature so we don't forget.
Regards,
-Denis
prev parent reply other threads:[~2010-08-13 15:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-10 9:57 [PATCH 0/2] huawei: PIN unlock working with E1552 Kalle Valo
2010-08-10 9:57 ` [PATCH 1/2] huawei: poll sim state Kalle Valo
2010-08-11 23:08 ` Denis Kenzior
2010-08-13 8:11 ` Kalle Valo
2010-08-10 9:57 ` [PATCH 2/2] huawei: postpone post_sim until SIM is ready Kalle Valo
2010-08-11 23:23 ` Denis Kenzior
2010-08-13 8:15 ` Kalle Valo
2010-08-13 15:38 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C656705.1030902@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox