From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 3/6] stemodem: Add support for STK.
Date: Fri, 13 Aug 2010 13:13:33 -0500 [thread overview]
Message-ID: <4C658B4D.6030605@gmail.com> (raw)
In-Reply-To: <1281696794-10891-3-git-send-email-sjur.brandeland@stericsson.com>
[-- Attachment #1: Type: text/plain, Size: 900 bytes --]
Hi Sjur,
> diff --git a/plugins/ste.c b/plugins/ste.c
> index f3ae0b2..ab48e18 100644
> --- a/plugins/ste.c
> +++ b/plugins/ste.c
> @@ -54,6 +54,7 @@
> #include <ofono/voicecall.h>
> #include <ofono/gprs.h>
> #include <ofono/gprs-context.h>
> +#include <ofono/stk.h>
> #include <drivers/atmodem/vendor.h>
>
> #include <drivers/stemodem/caif_socket.h>
> @@ -241,6 +242,7 @@ static void ste_post_sim(struct ofono_modem *modem)
>
> gprs = ofono_gprs_create(modem,
> OFONO_VENDOR_STE, "atmodem", data->chat);
> + ofono_stk_create(modem, 0, "stemodem", data->chat);
> gc = ofono_gprs_context_create(modem, 0, "stemodem", data->chat);
>
> if (gprs && gc)
If this is indeed just a copy of the mbm driver, can't you simply do
this part and use ofono_stk_create(modem, 0, "mbmmodem", data->chat) ?
It seems wasteful to copy parts around.
Regards,
-Denis
next prev parent reply other threads:[~2010-08-13 18:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-13 10:53 [PATCH 1/6] bugfix: distcheck fail due to rename of dataconnectionmanager-api.txt Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-08-13 10:53 ` [PATCH 2/6] stemodem: Copy if_caif.h from 2.6.36 release candidate Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-08-13 19:02 ` Denis Kenzior
2010-08-13 10:53 ` [PATCH 3/6] stemodem: Add support for STK Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-08-13 18:13 ` Denis Kenzior [this message]
2010-08-13 10:53 ` [PATCH 4/6] stemodem: Add SIM/PIN polling and SIM events Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-08-13 18:40 ` Denis Kenzior
2010-08-13 10:53 ` [PATCH 5/6] stemodem: Add Radio Settings to STE Modem Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-08-13 18:59 ` Denis Kenzior
2010-08-13 10:53 ` [PATCH 6/6] stemodem: Use RTNL for creating CAIF interface Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-08-13 19:01 ` [PATCH 1/6] bugfix: distcheck fail due to rename of dataconnectionmanager-api.txt Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C658B4D.6030605@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox