From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] sim: check pins even if language checks fails
Date: Wed, 25 Aug 2010 11:48:01 -0500 [thread overview]
Message-ID: <4C754941.40306@gmail.com> (raw)
In-Reply-To: <1282743841-25151-1-git-send-email-Pekka.Pessi@nokia.com>
[-- Attachment #1: Type: text/plain, Size: 762 bytes --]
Hi Pekka,
On 08/25/2010 08:44 AM, Pekka.Pessi(a)nokia.com wrote:
> From: Pekka Pessi <Pekka.Pessi@nokia.com>
>
> ---
> src/sim.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/src/sim.c b/src/sim.c
> index a450b30..be2793b 100644
> --- a/src/sim.c
> +++ b/src/sim.c
> @@ -1373,7 +1373,7 @@ skip_efpl:
> }
>
> if (sim->language_prefs == NULL)
> - return;
> + goto done;
>
> ofono_dbus_signal_array_property_changed(conn, path,
> OFONO_SIM_MANAGER_INTERFACE,
> @@ -1381,6 +1381,7 @@ skip_efpl:
> DBUS_TYPE_STRING,
> &sim->language_prefs);
>
> +done:
> sim_pin_check(sim);
> }
>
Good catch, I ended up solving it slightly differently.
Regards,
-Denis
prev parent reply other threads:[~2010-08-25 16:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-25 13:44 [PATCH] sim: check pins even if language checks fails Pekka.Pessi
2010-08-25 16:48 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C754941.40306@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox