From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] voicecall: Add check in dial_request_finish
Date: Mon, 30 Aug 2010 10:35:06 -0500 [thread overview]
Message-ID: <4C7BCFAA.40503@gmail.com> (raw)
In-Reply-To: <1283149713-19007-1-git-send-email-zhenhua.zhang@intel.com>
[-- Attachment #1: Type: text/plain, Size: 764 bytes --]
Hi Zhenhua,
On 08/30/2010 01:28 AM, Zhenhua Zhang wrote:
> To avoid signal 11 if no dial_req exists.
> ---
> src/voicecall.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/src/voicecall.c b/src/voicecall.c
> index 6ad58ad..1313129 100644
> --- a/src/voicecall.c
> +++ b/src/voicecall.c
> @@ -220,6 +220,9 @@ static void dial_request_finish(struct ofono_voicecall *vc, gboolean callback)
> {
> struct dial_request *dial_req = vc->dial_req;
>
> + if (dial_req == NULL)
> + return;
> +
> if (callback && dial_req->cb)
> dial_req->cb(dial_req->call ? dial_req->call->call : NULL,
> dial_req->user_data);
I fixed it slightly differently. Let me know if it still crashes.
Regards,
-Denis
prev parent reply other threads:[~2010-08-30 15:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-30 6:28 [PATCH] voicecall: Add check in dial_request_finish Zhenhua Zhang
2010-08-30 15:35 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C7BCFAA.40503@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox