From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 09/11] Driver API changed to accept DCS and any format string
Date: Wed, 01 Sep 2010 10:37:44 -0500 [thread overview]
Message-ID: <4C7E7348.9070202@gmail.com> (raw)
In-Reply-To: <1283338836-13572-9-git-send-email-jeevaka.badrappan@elektrobit.com>
[-- Attachment #1: Type: text/plain, Size: 1449 bytes --]
Hi Jeevaka,
On 09/01/2010 06:00 AM, Jeevaka Badrappan wrote:
> ---
> include/ussd.h | 8 +++++---
> 1 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/include/ussd.h b/include/ussd.h
> index 96e04cb..e3b43f7 100644
> --- a/include/ussd.h
> +++ b/include/ussd.h
> @@ -45,13 +45,15 @@ struct ofono_ussd_driver {
> const char *name;
> int (*probe)(struct ofono_ussd *ussd, unsigned int vendor, void *data);
> void (*remove)(struct ofono_ussd *ussd);
> - void (*request)(struct ofono_ussd *ussd, const char *str,
> - ofono_ussd_cb_t, void *data);
> + void (*request)(struct ofono_ussd *ussd, int dcs,
> + const unsigned char *str, int str_len,
> + ofono_ussd_cb_t, void *data);
> void (*cancel)(struct ofono_ussd *ussd,
> ofono_ussd_cb_t cb, void *data);
> };
>
> -void ofono_ussd_notify(struct ofono_ussd *ussd, int status, const char *str);
> +void ofono_ussd_notify(struct ofono_ussd *ussd, int status, int dcs,
> + const unsigned char *str, int str_len);
>
> int ofono_ussd_driver_register(const struct ofono_ussd_driver *d);
> void ofono_ussd_driver_unregister(const struct ofono_ussd_driver *d);
This patch modifies the driver API. All driver changes resulting from
this patch should follow after this patch. I'd move this patch to slot
#2 and patch #2 and #10 should come right after.
Regards,
-Denis
next prev parent reply other threads:[~2010-09-01 15:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-01 11:00 [PATCH 01/11] added Send USSD string maximum length Jeevaka Badrappan
2010-09-01 11:00 ` [PATCH 02/11] Changes done as per the changed driver API Jeevaka Badrappan
2010-09-01 12:49 ` Pekka Pessi
2010-09-01 15:12 ` Andrzej Zaborowski
2010-09-02 8:00 ` Jeevaka.Badrappan
2010-09-01 11:00 ` [PATCH 03/11] __ofono_call_barring_is_busy internal api for STK-Send USSD Jeevaka Badrappan
2010-09-01 15:22 ` Denis Kenzior
2010-09-01 11:00 ` [PATCH 04/11] __ofono_call_forwarding_is_busy " Jeevaka Badrappan
2010-09-01 15:23 ` Denis Kenzior
2010-09-01 11:00 ` [PATCH 05/11] __ofono_call_settings_is_busy " Jeevaka Badrappan
2010-09-01 11:00 ` [PATCH 06/11] Send USSD proactive command handling Jeevaka Badrappan
2010-09-01 15:35 ` Denis Kenzior
2010-09-01 16:43 ` andrzej zaborowski
2010-09-01 11:00 ` [PATCH 07/11] added stk_response_text_string for USSD result Jeevaka Badrappan
2010-09-01 15:33 ` Denis Kenzior
2010-09-02 0:22 ` andrzej zaborowski
2010-09-02 8:05 ` Jeevaka.Badrappan
2010-09-01 11:00 ` [PATCH 08/11] STK:Send USSD internal apis Jeevaka Badrappan
2010-09-01 11:00 ` [PATCH 09/11] Driver API changed to accept DCS and any format string Jeevaka Badrappan
2010-09-01 15:37 ` Denis Kenzior [this message]
2010-09-01 11:00 ` [PATCH 10/11] Changes done as per the changed driver API Jeevaka Badrappan
2010-09-01 11:00 ` [PATCH 11/11] __ofono_ussd_initiate internal api for STK-Send USSD Jeevaka Badrappan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C7E7348.9070202@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox