From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 1/1] Enable some atoms for hso modem
Date: Fri, 17 Sep 2010 07:59:13 -0500 [thread overview]
Message-ID: <4C936621.3080109@gmail.com> (raw)
In-Reply-To: <1284713422-3558-2-git-send-email-yang.gu@intel.com>
[-- Attachment #1: Type: text/plain, Size: 2063 bytes --]
Hi Yang,
> @@ -257,24 +266,40 @@ static void hso_pre_sim(struct ofono_modem *modem)
> ofono_devinfo_create(modem, 0, "atmodem", data->control);
> sim = ofono_sim_create(modem, OFONO_VENDOR_OPTION_HSO,
> "atmodem", data->control);
> + ofono_voicecall_create(modem, 0, "atmodem", data->app);
>
The Option hardware can never do audio, so enabling voice functionality
is not a good idea.
> if (sim)
> ofono_sim_inserted_notify(sim, TRUE);
> }
>
> +
> +static void hso_post_sim(struct ofono_modem *modem)
> +{
> + struct hso_data *data = ofono_modem_get_data(modem);
> +
> + DBG("%p", modem);
> +
> + ofono_phonebook_create(modem, 0, "atmodem", data->app);
> +}
> +
This is OK
> static void hso_post_online(struct ofono_modem *modem)
> {
> struct hso_data *data = ofono_modem_get_data(modem);
> + struct ofono_message_waiting *mw;
> struct ofono_gprs *gprs;
> struct ofono_gprs_context *gc;
>
> DBG("%p", modem);
>
> + ofono_call_forwarding_create(modem, 0, "atmodem", data->app);
> + ofono_call_settings_create(modem, 0, "atmodem", data->app);
> ofono_netreg_create(modem, OFONO_VENDOR_OPTION_HSO,
> "atmodem", data->app);
> -
> + ofono_call_meter_create(modem, 0, "atmodem", data->app);
> + ofono_call_barring_create(modem, 0, "atmodem", data->app);
> + ofono_ssn_create(modem, 0, "atmodem", data->app);
> + ofono_call_volume_create(modem, 0, "atmodem", data->app);
> ofono_radio_settings_create(modem, 0, "hsomodem", data->app);
> -
> ofono_sms_create(modem, OFONO_VENDOR_OPTION_HSO, "atmodem", data->app);
> ofono_cbs_create(modem, OFONO_VENDOR_QUALCOMM_MSM,
> "atmodem", data->app);
> @@ -286,6 +311,10 @@ static void hso_post_online(struct ofono_modem *modem)
>
> if (gprs && gc)
> ofono_gprs_add_context(gprs, gc);
> +
> + mw = ofono_message_waiting_create(modem);
> + if (mw)
> + ofono_message_waiting_register(mw);
Same thing here, since voicecalls are not enabled, all the call-*
related atoms are not needed.
Regards,
-Denis
next prev parent reply other threads:[~2010-09-17 12:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-17 8:50 [PATCH 0/1] Patch Description Yang Gu
2010-09-17 8:50 ` [PATCH 1/1] Enable some atoms for hso modem Yang Gu
2010-09-17 9:00 ` Marcel Holtmann
2010-09-17 12:59 ` Denis Kenzior [this message]
2010-09-19 7:37 ` Gu, Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C936621.3080109@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox