From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 1/2] Fix valid_ussd_string()
Date: Thu, 23 Sep 2010 13:27:41 -0500 [thread overview]
Message-ID: <4C9B9C1D.6070803@gmail.com> (raw)
In-Reply-To: <1285263737-9017-1-git-send-email-Pekka.Pessi@nokia.com>
[-- Attachment #1: Type: text/plain, Size: 878 bytes --]
Hi Pekka,
> - * According to 22.030 Figure 3.5.3.2 USSD strings can be:
> - *
> - * Supplementary service control
> - * SIM control
> - * Manufacturer defined
> - * Terminated by '#'
> - * Short String - This can be any 2 digit short string. If the string
> - * starts with a '1' and no calls are in progress then
> - * this string is treated as a call setup request
> - *
> - * Everything else is not a valid USSD string
> + * As an exception, if a 2 digit string starts with a '1' and
> + * there are no calls in progress then this string is treated as
> + * a call setup request instead.
You are now removing any reference to 22.030 and simply stating the
'facts'. I prefer that the spec trail be left in. So at least these
comments should not be removed.
The rest looks fine to me.
Regards,
-Denis
prev parent reply other threads:[~2010-09-23 18:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-23 17:42 [PATCH 1/2] Fix valid_ussd_string() Pekka.Pessi
2010-09-23 17:42 ` [PATCH 2/2] Fix __ofono_voicecall_is_busy() Pekka.Pessi
2010-09-23 18:30 ` Denis Kenzior
2010-09-23 18:27 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9B9C1D.6070803@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox