Re: [PATCH 1/5] Add macro for general result and additional info

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1882 bytes --]

Hi Yang,

On 09/21/2010 05:21 AM, Yang Gu wrote:
> ---
>  src/stkutil.h |   23 +++++++++++++++++++++++
>  1 files changed, 23 insertions(+), 0 deletions(-)
> 
> diff --git a/src/stkutil.h b/src/stkutil.h
> index 36b18f0..645daf8 100644
> --- a/src/stkutil.h
> +++ b/src/stkutil.h
> @@ -254,6 +254,8 @@ enum stk_result_type {
>  	STK_RESULT_TYPE_COMMAND_NOT_UNDERSTOOD =	0x31,
>  	STK_RESULT_TYPE_DATA_NOT_UNDERSTOOD =		0x32,
>  	STK_RESULT_TYPE_COMMAND_ID_UNKNOWN =		0x33,
> +	STK_RESULT_TYPE_SS_RETURN_ERROR =		0x34,
> +	STK_RESULT_TYPE_SMS_RP_ERROR =			0x35,
>  	STK_RESULT_TYPE_MINIMUM_NOT_MET =		0x36,
>  	STK_RESULT_TYPE_USSD_RETURN_ERROR =		0x37,
>  	STK_RESULT_TYPE_CALL_CONTROL_PERMANENT =	0x39,
> @@ -263,6 +265,27 @@ enum stk_result_type {
>  	STK_RESULT_TYPE_MMS_ERROR =			0x3D,
>  };
>  
> +enum stk_result_addnl_me_pb_fb {
> +	STK_RESULT_ADDNL_ME_PB_NO_SPECIFIC_CAUSE =	0x00,
> +	STK_RESULT_ADDNL_ME_PB_SCREEN_BUSY =		0x01,
> +	STK_RESULT_ADDNL_ME_PB_BUSY_ON_CALL =		0x02,
> +	STK_RESULT_ADDNL_ME_PB_NO_SERVICE =		0x04,
> +	STK_RESULT_ADDNL_ME_PB_NO_ACCESS =		0x05,
> +	STK_RESULT_ADDNL_ME_PB_NO_RADIO_RESOURCE =	0x06,
> +	STK_RESULT_ADDNL_ME_PB_NOT_IN_SPEECH_CALL =	0x07,
> +	STK_RESULT_ADDNL_ME_PB_BUSY_ON_SEND_DTMF =	0x09,
> +	STK_RESULT_ADDNL_ME_PB_NO_NAA_ACTIVE =		0x0A
> +};

Can you include a comment as to where these values are coming from?
What does ME_PB_FB stand for?

> +
> +enum stk_result_addnl_me_pb_ob {
> +	STK_RESULT_ADDNL_ME_PB_SS_BUSY =	0x03,
> +	STK_RESULT_ADDNL_ME_PB_USSD_BUSY =	0x08
> +};
> +

Same for this one..

> +enum stk_result_addnl_ss_pb_ob {
> +	STK_RESULT_ADDNL_SS_PB_NO_SPECIFIC_CAUSE =	0x00
> +};
> +

And for this one, I assume this is from 31.111 8.12.3?

>  enum stk_tone_type {
>  	STK_TONE_TYPE_DIAL_TONE =	0x01,
>  	STK_TONE_TYPE_BUSY_TONE =	0x02,

Regards,
-Denis