From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] stk: Additional info for failed Send USSD case
Date: Thu, 30 Sep 2010 19:11:03 -0500 [thread overview]
Message-ID: <4CA52717.1030009@gmail.com> (raw)
In-Reply-To: <1285763296-7208-2-git-send-email-jeevaka.badrappan@elektrobit.com>
[-- Attachment #1: Type: text/plain, Size: 893 bytes --]
Hi Jeevaka,
> + unsigned char addnl;
Lets try to be consistent with other parts of stk.c.
Use unsigned char no_cause[] = { 0x00 };
>
> if (stk->pending_cmd->send_ussd.alpha_id &&
> stk->pending_cmd->send_ussd.alpha_id[0])
> @@ -1661,7 +1662,14 @@ static void send_ussd_callback(int error, int dcs, const unsigned char *msg,
> break;
>
> default:
> - send_simple_response(stk, STK_RESULT_TYPE_USSD_RETURN_ERROR);
> + rsp.result.type = STK_RESULT_TYPE_USSD_RETURN_ERROR;
> + addnl = 0; /* No specific cause can be given */
> + rsp.result.additional = &addnl;
> + rsp.result.additional_len = 1;
> +
Then rsp.result.additional_len = sizeof(no_cause);
rsp.result.additional = no_cause
> + if (stk_respond(stk, &rsp, stk_command_cb))
> + stk_command_cb(&failure, stk);
> +
> break;
> }
> }
Otherwise looks good.
Regards,
-Denis
next prev parent reply other threads:[~2010-10-01 0:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-29 12:28 Additional info for failed SAT-Send USSD case Jeevaka Badrappan
2010-09-29 12:28 ` [PATCH] stk: Additional info for failed Send " Jeevaka Badrappan
2010-10-01 0:11 ` Denis Kenzior [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-10-01 6:32 Jeevaka Badrappan
2010-10-02 22:25 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA52717.1030009@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox