Open Source Telephony
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [RFC online/offline atoms PATCH 2/4] sms: watch modem state
Date: Tue, 05 Oct 2010 19:38:33 -0500	[thread overview]
Message-ID: <4CABC509.2080502@gmail.com> (raw)
In-Reply-To: <1286279995.17473.81.camel@aeonflux>

[-- Attachment #1: Type: text/plain, Size: 795 bytes --]

Hi Marcel,

On 10/05/2010 06:59 AM, Marcel Holtmann wrote:
> Hi Pekka,
> 
>> Allow use of SMS atom in online and offline states.  The messages are
>> queued but not sent in offline mode. Errors occurring when an SMS is
>> being sent while transition from online to offline are handled
>> gracefully.
> 
> do we really want this? How is this suppose to work from the user
> experience. I think just failing SendMessage with a proper error is a
> more clear indication.

That is a valid point, the code should be able to handle this use case,
but from a UI stand point I don't know what is better.

The main reason for moving sms atom from online to offline is the
ability to switch the settings.  In particular the SMSC address which is
stored on the SIM.

Regards,
-Denis

  reply	other threads:[~2010-10-06  0:38 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-05 11:35 [RFC online/offline atoms PATCH 0/4] modem: add modem state watch Pekka.Pessi
2010-10-05 11:35 ` [RFC online/offline atoms PATCH 1/4] " Pekka.Pessi
2010-10-05 11:35   ` [RFC online/offline atoms PATCH 2/4] sms: watch modem state Pekka.Pessi
2010-10-05 11:35     ` [RFC online/offline atoms PATCH 3/4] gprs: " Pekka.Pessi
2010-10-05 11:35       ` [RFC online/offline atoms PATCH 4/4] isigen: create sms and gprs in post_sim Pekka.Pessi
2010-10-05 12:04         ` Marcel Holtmann
2010-10-06  0:40           ` Denis Kenzior
2010-10-06  8:55             ` Marcel Holtmann
2010-10-13 20:53       ` [RFC online/offline atoms PATCH 3/4] gprs: watch modem state Denis Kenzior
2010-10-05 11:59     ` [RFC online/offline atoms PATCH 2/4] sms: " Marcel Holtmann
2010-10-06  0:38       ` Denis Kenzior [this message]
2010-10-06  8:54         ` Marcel Holtmann
2010-10-13 20:45     ` Denis Kenzior
2010-10-05 11:56   ` [RFC online/offline atoms PATCH 1/4] modem: add modem state watch Marcel Holtmann
2010-10-13 20:39   ` Denis Kenzior
2010-10-14  7:21     ` Pekka Pessi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CABC509.2080502@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox