Open Source Telephony
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [ussd-mmi PATCH 1/4] Fix valid_ussd_string()
Date: Sun, 10 Oct 2010 06:08:23 -0500	[thread overview]
Message-ID: <4CB19EA7.9000708@gmail.com> (raw)
In-Reply-To: <1286376739-20677-2-git-send-email-Pekka.Pessi@nokia.com>

[-- Attachment #1: Type: text/plain, Size: 871 bytes --]

Hi Pekka,

On 10/06/2010 09:52 AM, Pekka.Pessi(a)nokia.com wrote:
> From: Pekka Pessi <Pekka.Pessi@nokia.com>
> 
> The valid_ussd_string() returns now true if MMI input is to be sent as
> USSD.
> 
> The comment about USSD routing is removed, it is out of scope of oFono.
> The cellular network routes the USSD requests based on the rules laid
> out in the 22.090, however, any string that can be encoded according to
> the rules of 23.038 is valid USSD.
> ---
>  src/common.c |   44 +++++++++++++++++++-------------------------
>  src/common.h |    2 +-
>  src/ussd.c   |   13 ++++++++++++-
>  3 files changed, 32 insertions(+), 27 deletions(-)
> 

Somehow this patch got mangled, so I had to be creative when trying to
apply it.  I broke it up into two patches and fixed up the style slightly.

Patch has been applied, thanks.

Regards,
-Denis

      parent reply	other threads:[~2010-10-10 11:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-06 14:52 [ussd-mmi PATCH 0/4] Pekka.Pessi
2010-10-06 14:52 ` [ussd-mmi PATCH 1/4] Fix valid_ussd_string() Pekka.Pessi
2010-10-06 14:52   ` [ussd-mmi PATCH 2/4] Check stk requests in __ofono_voicecall_is_busy() Pekka.Pessi
2010-10-06 14:52     ` [ussd-mmi PATCH 3/4] voicecall: remove dial_request_finish() cb param Pekka.Pessi
2010-10-06 14:52       ` [ussd-mmi PATCH 4/4] voicecall: check g_try_new0 return value Pekka.Pessi
2010-10-10 11:09         ` Denis Kenzior
2010-10-10 11:09       ` [ussd-mmi PATCH 3/4] voicecall: remove dial_request_finish() cb param Denis Kenzior
2010-10-10 11:08     ` [ussd-mmi PATCH 2/4] Check stk requests in __ofono_voicecall_is_busy() Denis Kenzior
2010-10-10 11:08   ` Denis Kenzior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CB19EA7.9000708@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox