Re: [PATCH v2 0/3] Patch Description

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1007 bytes --]

Hi Yang,

On 10/14/2010 06:17 AM, Gu, Yang wrote:
> Hi Denis,
> 
> 
>>> Then we set the path of script and run the script with its name
>>> dbus-send --system --print-reply --dest=org.phonesim /
>> org.phonesim.Script.SetPath string:/tmp/call
>>> dbus-send --system --print-reply --dest=org.phonesim / org.phonesim.Script.Run
>> string:call.js
>>>
>>
>> One of the changes I made was to have phonesim register to the system
>> bus.  This makes the above DBus configuration file unnecessary.  Running
>> phonesim on the system bus was too much of a security risk, and wasn't
>> really needed.
>>
> 
> Thanks for the modifications afterward, and I'm fine with most of them. One question is why you renamed the service name to "org.ofono.phonesim". I wonder why the phonesim should have relationship with ofono?

In theory the service name should be related to the project website /
domain name.  Since we do not own org.phonesim, we put it on the
org.ofono prefix.

Regards,
-Denis