From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [RFC PATCH 1/8] simfs: add logic to retrieve only only EF-info, but no EF-contents
Date: Fri, 15 Oct 2010 07:19:53 -0500 [thread overview]
Message-ID: <4CB846E9.2070507@gmail.com> (raw)
In-Reply-To: <1287090175-3018-2-git-send-email-petteri.tikander@ixonos.com>
[-- Attachment #1: Type: text/plain, Size: 711 bytes --]
Hi Petteri,
On 10/14/2010 04:02 PM, Petteri Tikander wrote:
> Handling of new parameter (file status) from the driver added.
> This commit doesn't store EF-info into cache yet.
Please keep your commit header to less than 50 characters.
> + if (op->info_only) {
> + /*
> + * It's info-only request. So there is no need to request
> + * actual contents of the EF-files. Just return the EF-info.
> + */
> + cb(1, op->length, op->current,
> + &file_status, op->record_length, op->userdata);
> +
So I honestly don't like us using the ofono_sim_file_read_cb_t for the
callback in the info only case. Can we invent a new callback type
specifically for this case?
Regards,
-Denis
prev parent reply other threads:[~2010-10-15 12:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-14 21:02 Handling of Fixed Dialing v4 Petteri Tikander
2010-10-14 21:02 ` [RFC PATCH 1/8] simfs: add logic to retrieve only only EF-info, but no EF-contents Petteri Tikander
2010-10-14 21:02 ` [RFC PATCH 2/8] simutil: response-handler returns now also file-status Petteri Tikander
2010-10-14 21:02 ` [RFC PATCH 3/8] sim: add new parameter to file-info utility Petteri Tikander
2010-10-14 21:02 ` [RFC PATCH 4/8] atmodem: returns file-status of SIM EF-file Petteri Tikander
2010-10-14 21:02 ` [RFC PATCH 5/8] isimodem: " Petteri Tikander
2010-10-14 21:02 ` [RFC PATCH 6/8] sim: add function for reading only general info from SIM-EF file Petteri Tikander
2010-10-14 21:02 ` [RFC PATCH 7/8] sim: check if Fixed Dialing is enabled in the SIM-card Petteri Tikander
2010-10-14 21:02 ` [RFC PATCH 8/8] doc: update sim-api Petteri Tikander
2010-10-15 12:28 ` Denis Kenzior
2010-10-15 12:33 ` [RFC PATCH 7/8] sim: check if Fixed Dialing is enabled in the SIM-card Denis Kenzior
2010-10-15 12:32 ` [RFC PATCH 6/8] sim: add function for reading only general info from SIM-EF file Denis Kenzior
2010-10-15 12:27 ` [RFC PATCH 5/8] isimodem: returns file-status of SIM EF-file Denis Kenzior
2010-10-15 12:26 ` [RFC PATCH 4/8] atmodem: " Denis Kenzior
2010-10-15 12:21 ` [RFC PATCH 3/8] sim: add new parameter to file-info utility Denis Kenzior
2010-10-15 12:20 ` [RFC PATCH 2/8] simutil: response-handler returns now also file-status Denis Kenzior
2010-10-15 12:19 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CB846E9.2070507@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox