From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 2/4] stk: Handle the Send DTMF proactive command.
Date: Fri, 22 Oct 2010 22:55:48 -0500 [thread overview]
Message-ID: <4CC25CC4.5080503@gmail.com> (raw)
In-Reply-To: <1287637748-7230-2-git-send-email-andrew.zaborowski@intel.com>
[-- Attachment #1: Type: text/plain, Size: 819 bytes --]
Hi Andrew,
On 10/21/2010 12:09 AM, Andrzej Zaborowski wrote:
> The default_agent_notify and session_agent_notify changes below are
> needed for respond_on_exit commands to be able to free up their
> resources, reset alpha id, etc. Commands other than Send DTMF that
> use respond_on_exit are all associated with a agent method call and
> get notified about agent exit in the callback.
> ---
> src/stk.c | 143 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
> 1 files changed, 142 insertions(+), 1 deletions(-)
>
Patch has been applied, thanks.
I did find one minor error here:
> + if (error == EINVAL)
> + send_simple_response(stk, STK_RESULT_TYPE_DATA_NOT_UNDERSTOOD);
Seems positive EINVAL can never be returned. If I missed something, let
me know.
Regards,
-Denis
next prev parent reply other threads:[~2010-10-23 3:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 5:09 [PATCH 1/4] voicecall: __ofono_voicecall_tone_send internal api Andrzej Zaborowski
2010-10-21 5:09 ` [PATCH 2/4] stk: Handle the Send DTMF proactive command Andrzej Zaborowski
2010-10-23 3:55 ` Denis Kenzior [this message]
2010-10-21 5:09 ` [PATCH 3/4] atmodem: Delay return from send_dtmf Andrzej Zaborowski
2010-10-23 3:56 ` Denis Kenzior
2010-10-21 5:09 ` [PATCH 4/4] stk: Apply STK text attributes as html Andrzej Zaborowski
2010-10-23 3:56 ` Denis Kenzior
2010-10-23 3:54 ` [PATCH 1/4] voicecall: __ofono_voicecall_tone_send internal api Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC25CC4.5080503@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox