From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] simfs: Fix issue with sim_fs_op_error
Date: Sun, 24 Oct 2010 09:13:47 -0500 [thread overview]
Message-ID: <4CC43F1B.5000907@gmail.com> (raw)
In-Reply-To: <1287921843-18631-2-git-send-email-jeevaka.badrappan@elektrobit.com>
[-- Attachment #1: Type: text/plain, Size: 743 bytes --]
Hi Jeevaka,
On 10/24/2010 07:04 AM, Jeevaka Badrappan wrote:
> ---
> src/simfs.c | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/src/simfs.c b/src/simfs.c
> index 4204aca..1e71f82 100644
> --- a/src/simfs.c
> +++ b/src/simfs.c
> @@ -142,7 +142,10 @@ static void sim_fs_op_error(struct sim_fs *fs)
> {
> struct sim_fs_op *op = g_queue_peek_head(fs->op_q);
>
> - if (op->is_read == TRUE)
> + if (op->info_only == TRUE)
> + ((sim_fs_read_info_cb_t) op->cb)
> + (0, 0, 0, 0, op->userdata);
> + else if (op->is_read == TRUE)
> ((ofono_sim_file_read_cb_t) op->cb)
> (0, 0, 0, 0, 0, op->userdata);
> else
Good catch. Patch has been applied, thanks.
Regards,
-Denis
prev parent reply other threads:[~2010-10-24 14:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-24 12:04 Fix issue in sim_fs_op_error Jeevaka Badrappan
2010-10-24 12:04 ` [PATCH] simfs: Fix issue with sim_fs_op_error Jeevaka Badrappan
2010-10-24 14:13 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC43F1B.5000907@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox