Open Source Telephony
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] calypsomodem: Notify core about commands handled in modem.
Date: Wed, 27 Oct 2010 12:27:23 -0500	[thread overview]
Message-ID: <4CC860FB.50109@gmail.com> (raw)
In-Reply-To: <1288083128-24058-2-git-send-email-andrew.zaborowski@intel.com>

[-- Attachment #1: Type: text/plain, Size: 799 bytes --]

Hi Andrew,

>  	/*
> -	 * Proactive command has been handled by the modem.  Should
> -	 * the core be notified?  For now we just ignore it because
> -	 * we must not respond to the command.
> +	 * A proactive command starts with a Proactive UICC Command BER-TLV
> +	 * short tag (0xd0) with optional pad bytes, a Terminal Response
> +	 * starts with the Command Details CTLV tag (0x81).
>  	 */
> +	if (pdu[0] != 0x81)
> +		ofono_stk_proactive_command_handled_notify(stk, len, pdu);
> +	else
> +		ofono_stk_terminal_response_sent_notify(stk, len, pdu);
>  }

I removed terminal_response_sent_notify from the API and took care of
this in the core.  I also went ahead and fixed up the three drivers in
question.  Can you double check that I didn't screw this up?

Thanks,
-Denis

  reply	other threads:[~2010-10-27 17:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-26  8:52 [PATCH] stk: Handle more commands in proactive_command_handled_notify Andrzej Zaborowski
2010-10-26  8:52 ` [PATCH] calypsomodem: Notify core about commands handled in modem Andrzej Zaborowski
2010-10-27 17:27   ` Denis Kenzior [this message]
2010-10-26  8:52 ` [PATCH] mbmmodem: " Andrzej Zaborowski
2010-10-26  8:52 ` [PATCH] ifxmodem: " Andrzej Zaborowski
2010-10-26 22:03   ` Marcel Holtmann
2010-10-27 17:01 ` [PATCH] stk: Handle more commands in proactive_command_handled_notify Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CC860FB.50109@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox