From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] TODO: Add owner to extend the voicecall interface with a property indicating emergency call
Date: Wed, 10 Nov 2010 08:33:23 -0600 [thread overview]
Message-ID: <4CDAAD33.3070901@gmail.com> (raw)
In-Reply-To: <1289391944-3184-1-git-send-email-john.mathew@elektrobit.com>
[-- Attachment #1: Type: text/plain, Size: 1186 bytes --]
Hi John,
On 11/10/2010 06:25 AM, John Mathew wrote:
> ---
> TODO | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/TODO b/TODO
> index 84d5aa7..ed37c58 100644
> --- a/TODO
> +++ b/TODO
> @@ -416,7 +416,7 @@ Emergency Calls
>
> Priority: High
> Complexity: C1
> -
> + Owner: John Mathew <john.mathew@elektrobit.com>
>
> Miscellaneous
> =============
We have pretty strict git apply settings in effect, so your patch does
not apply:
Applying: TODO: Add owner to extend the voicecall interface with a
property indicating emergency call
/home/denkenz/ofono-master/.git/rebase-apply/patch:14: trailing whitespace.
Owner: John Mathew <john.mathew@elektrobit.com>
fatal: 1 line adds whitespace errors.
Patch failed at 0001 TODO: Add owner to extend the voicecall interface
with a property indicating emergency call
Also, please keep your commit header under 50 characters. And yes, I
know the task description is rather 'long' in this case ;) So sometimes
we have to be a bit 'creative'. Something like:
"TODO: Assign Voicecall emergency property task"
would work in this case.
Regards,
-Denis
next prev parent reply other threads:[~2010-11-10 14:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-10 12:25 [PATCH] TODO: Add owner to extend the voicecall interface with a property indicating emergency call John Mathew
2010-11-10 14:33 ` Denis Kenzior [this message]
2010-11-10 16:09 ` John Mathew
2010-11-10 16:09 ` [PATCH] TODO: Assign Voicecall emergency property task John Mathew
2010-11-10 16:13 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CDAAD33.3070901@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox