Re: [PATCH] Add SIM reset button

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1403 bytes --]

Hi Gustavo,

On 11/16/2010 02:48 PM, Gustavo F. Padovan wrote:
> +CRST now send a reset resquest command
> ---
>  src/control.cpp    |    6 ++++++
>  src/control.h      |    1 +
>  src/controlbase.ui |   40 ++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 47 insertions(+), 0 deletions(-)
> 
> diff --git a/src/control.cpp b/src/control.cpp
> index ab71752..014e657 100644
> --- a/src/control.cpp
> +++ b/src/control.cpp
> @@ -84,6 +84,7 @@ ControlWidget::ControlWidget(const QString &ruleFile, Control *parent)
>      connect(ui->cbSimInserted, SIGNAL(clicked()), this, SLOT(simInsertRemove()));
>      connect(ui->pbStart, SIGNAL(clicked()), this, SLOT(simAppStart()));
>      connect(ui->pbAbort, SIGNAL(clicked()), this, SLOT(simAppAbort()));
> +    connect(ui->pbReset, SIGNAL(clicked()), this, SLOT(simAppReset()));
>  
>      QStringList headers;
>      headers << "Sender" << "Priority" << "Notification Status";
> @@ -466,6 +467,11 @@ void ControlWidget::simAppAbort()
>      p->simAppAbort();
>  }
>  
> +void ControlWidget::simAppReset()

Can you rename this slot into modemSilentReset or something?  This
really has nothing to do with the SIM Application.

> +{
> +    emit unsolicitedCommand("+CRST:");
> +}
> +
>  Script::Script(QObject *obj, Ui_ControlBase *ui) : QDBusAbstractAdaptor(obj)
>  {

Otherwise looks good

Regards,
-Denis