From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 3/3] Add Lockdown property to Modem interface
Date: Tue, 23 Nov 2010 15:43:12 -0600 [thread overview]
Message-ID: <4CEC3570.7050709@gmail.com> (raw)
In-Reply-To: <20101123175314.GC22502@vigoh>
[-- Attachment #1: Type: text/plain, Size: 1247 bytes --]
Hi Gustavo,
On 11/23/2010 11:53 AM, Gustavo F. Padovan wrote:
>>> + boolean Lockdown [readwrite]
>>> +
>>> + Boolean representing the lock state of the modem.
>>> + Setting it to true, makes the calling application hold
>>> + the modem lock and power it down. Setting to false
>>> + makes the it restore the modem state before the
>>> + lockdown and release the modem lock. Only the
>>> + application that holds the lock can power up the modem.
>>> + If the the application exits Lockdown is set to false.
>>> +
>>
>> So me and Marcel discussed this briefly and I think we want to modify
>> the behavior slightly. When Lockdown is set to True, the modem should
>> be brought down to Powered=Off state, and setting the Powered property
>> should return an error.
>
> That's what my code does.
>
Yep.
>>
>> When Lockdown is set to False from True, only the lock is lifted.
>> Powered state still has to be triggered manually. This should make the
>> implementation a little simpler.
>
> So this also means that we shall not restore the modem state when
> someone set Powered to true?
>
No, lets forget doing this for now. I think it was making things too
complicated.
Regards,
-Denis
next prev parent reply other threads:[~2010-11-23 21:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-19 21:37 [PATCH 1/3] TODO: Add owner to implement the Lockdown property Gustavo F. Padovan
2010-11-19 21:37 ` [PATCH 2/3] Add __ofono_error_access_denied() Gustavo F. Padovan
2010-11-19 21:37 ` [PATCH 3/3] Add Lockdown property to Modem interface Gustavo F. Padovan
2010-11-19 22:20 ` [PATCH] Add test script for the Lockdown property Gustavo F. Padovan
2010-11-23 13:50 ` [PATCH 3/3] Add Lockdown property to Modem interface Denis Kenzior
2010-11-23 17:53 ` Gustavo F. Padovan
2010-11-23 21:43 ` Denis Kenzior [this message]
2010-11-23 11:12 ` [PATCH 2/3] Add __ofono_error_access_denied() Denis Kenzior
2010-11-23 11:05 ` [PATCH 1/3] TODO: Add owner to implement the Lockdown property Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CEC3570.7050709@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox