Open Source Telephony
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH v2 4/7] text-telephony: implement interface/atom
Date: Wed, 24 Nov 2010 15:29:40 -0600	[thread overview]
Message-ID: <4CED83C4.7020804@gmail.com> (raw)
In-Reply-To: <AANLkTinOgx874zT-gixdYNYVO_-7u3gobscRsv4-4Xxz@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 707 bytes --]

Hi Lucas,

>>> +     tt_set_powered(tt, enable);
>>> +     tt_send_properties_reply(tt);
>>
>> The oFono convention is to reply to the pending D-Bus method call and
>> then signal the property changed signals.
>>
> 
> The examples I found for query methods use exactly the opposite. See,
> cw_ss_query_callback() in call-settings.c and
> radio_fast_dormancy_query_callback() in radio-settings.c.

So we do prefer the reply before the signal.  However, we're still a bit
inconsistent in this area because multi-property queries make this very
hard.  In the single property case it is doable, but I'm fine accepting
this part as is.  So feel free to ignore this feedback.

Regards,
-Denis

  reply	other threads:[~2010-11-24 21:29 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-23 18:04 Add text telephony support Lucas De Marchi
2010-11-23 18:04 ` [PATCH v2 1/7] text-telephony: add public header Lucas De Marchi
2010-11-24 15:28   ` Denis Kenzior
2010-11-23 18:04 ` [PATCH v2 2/7] text-telephony: define new dbus interface Lucas De Marchi
2010-11-24 15:26   ` Denis Kenzior
2010-11-23 18:04 ` [PATCH v2 3/7] text-telephony: add new interface to feature map Lucas De Marchi
2010-11-24 15:26   ` Denis Kenzior
2010-11-23 18:04 ` [PATCH v2 4/7] text-telephony: implement interface/atom Lucas De Marchi
2010-11-24 15:58   ` Denis Kenzior
2010-11-24 18:51     ` Lucas De Marchi
2010-11-24 21:29       ` Denis Kenzior [this message]
2010-11-25 11:26         ` Lucas De Marchi
2010-11-23 18:04 ` [PATCH v2 5/7] text-telephony: add documentation Lucas De Marchi
2010-11-24 15:25   ` Denis Kenzior
2010-11-25  9:53   ` Kai.Vehmanen
2010-11-23 18:04 ` [PATCH v2 6/7] phonesim: implement text-telephony atom Lucas De Marchi
2010-11-23 18:04 ` [PATCH v2 7/7] Add script to enable/disable text-telephony support Lucas De Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CED83C4.7020804@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox