Open Source Telephony
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 1/5] text-telephony: add public header
Date: Mon, 29 Nov 2010 07:53:17 -0600	[thread overview]
Message-ID: <4CF3B04D.4080704@gmail.com> (raw)
In-Reply-To: <97D5E1BB8FC13D4EA3B34BAE8E6898C90157E6BCB6@orsmsx508.amr.corp.intel.com>

[-- Attachment #1: Type: text/plain, Size: 792 bytes --]

Hi Waldo,

On 11/27/2010 03:04 PM, Bastian, Waldo wrote:
>>> +	void (*remove)(struct ofono_ctm *tt);
>>> +	void (*query_tty)(struct ofono_ctm *tt,
>>> +				ofono_ctm_query_cb_t cb,
>>> +				void *data);
>>> +	void (*set_tty)(struct ofono_ctm *tt,
>>> +				int enable,
>>
>> I also changed this to ofono_bool_t enable
> 
> Fyi, I noticed that radio-settings.h has this as an int as well:
> 
> 67         void (*set_fast_dormancy)(struct ofono_radio_settings *rs,
> 68                                 int enable,
> 69                                 ofono_radio_settings_fast_dormancy_set_cb_t,
> 70                                 void *data);
> 
> The query callback otoh uses ofono_bool_t.
> 

Thanks for pointing this out.  It has now been fixed.

Regards,
-Denis

      reply	other threads:[~2010-11-29 13:53 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-25 17:41 [PATCH 1/5] text-telephony: add public header Lucas De Marchi
2010-11-25 17:41 ` [PATCH 2/5] text-telephony: implement interface/atom Lucas De Marchi
2010-11-26 19:28   ` Denis Kenzior
2010-11-25 17:41 ` [PATCH 3/5] text-telephony: add documentation Lucas De Marchi
2010-11-26 19:29   ` Denis Kenzior
2010-11-25 17:41 ` [PATCH 4/5] phonesim: implement text-telephony atom Lucas De Marchi
2010-11-26 19:17   ` Denis Kenzior
2010-11-27  0:44     ` [PATCH] phonesim: implement ctm atom Lucas De Marchi
2010-11-27 18:00       ` Denis Kenzior
2010-11-27 19:22         ` [PATCH 1/2] " Lucas De Marchi
2010-11-29 16:44           ` Denis Kenzior
2010-11-27 19:22         ` [PATCH 2/2] TODO: Mark CTM task as done Lucas De Marchi
2010-11-29 16:44           ` Denis Kenzior
2010-11-25 17:42 ` [PATCH 5/5] Add script to enable/disable text-telephony support Lucas De Marchi
2010-11-26 19:29   ` Denis Kenzior
2010-11-26 19:27 ` [PATCH 1/5] text-telephony: add public header Denis Kenzior
2010-11-27 21:04   ` Bastian, Waldo
2010-11-29 13:53     ` Denis Kenzior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CF3B04D.4080704@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox