From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 9/9] core: explicitly compare pointers to NULL
Date: Mon, 29 Nov 2010 14:52:01 -0600 [thread overview]
Message-ID: <4CF41271.1040504@gmail.com> (raw)
In-Reply-To: <1290886743-24561-9-git-send-email-lucas.demarchi@profusion.mobi>
[-- Attachment #1: Type: text/plain, Size: 1958 bytes --]
Hi Lucas,
On 11/27/2010 01:39 PM, Lucas De Marchi wrote:
> This patch was generated by the following semantic patch
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @fix disable is_null,isnt_null1@
> expression *E;
> @@
>
> - !E
> + E == NULL
> // </smpl>
> ---
> src/audio-settings.c | 12 ++++----
> src/call-barring.c | 18 ++++++------
> src/call-forwarding.c | 20 +++++++-------
> src/call-meter.c | 26 +++++++++---------
> src/call-settings.c | 26 +++++++++---------
> src/call-volume.c | 6 ++--
> src/cbs.c | 16 +++++-----
> src/common.c | 2 +-
> src/dbus.c | 8 +++---
> src/gprs.c | 28 ++++++++++----------
> src/history.c | 2 +-
> src/main.c | 2 +-
> src/message-waiting.c | 4 +-
> src/modem.c | 14 +++++-----
> src/nettime.c | 2 +-
> src/network.c | 28 ++++++++++----------
> src/phonebook.c | 10 +++---
> src/plugin.c | 2 +-
> src/radio-settings.c | 20 +++++++-------
> src/sim.c | 16 +++++-----
> src/simfs.c | 28 ++++++++++----------
> src/simutil.c | 16 +++++-----
> src/sms.c | 40 ++++++++++++++--------------
> src/smsagent.c | 12 ++++----
> src/smsutil.c | 34 ++++++++++++------------
> src/stk.c | 62 +++++++++++++++++++++---------------------
> src/stkagent.c | 2 +-
> src/stkutil.c | 4 +-
> src/ussd.c | 46 ++++++++++++++++----------------
> src/util.c | 14 +++++-----
> src/voicecall.c | 70 ++++++++++++++++++++++++------------------------
> 31 files changed, 295 insertions(+), 295 deletions(-)
>
I applied this patch but broke it up into several for the core files I
really want to track separately. Thanks for doing all this.
Regards,
-Denis
next prev parent reply other threads:[~2010-11-29 20:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-27 19:38 [PATCH 1/9] coding-style: add rule about checking NULL pointer Lucas De Marchi
2010-11-27 19:38 ` [PATCH 2/9] drivers: explicitly compare pointers to NULL Lucas De Marchi
2010-11-29 20:48 ` Denis Kenzior
2010-11-27 19:38 ` [PATCH 3/9] unit: " Lucas De Marchi
2010-11-29 20:49 ` Denis Kenzior
2010-11-27 19:38 ` [PATCH 4/9] gisi: " Lucas De Marchi
2010-11-29 20:49 ` Denis Kenzior
2010-11-27 19:38 ` [PATCH 5/9] examples: " Lucas De Marchi
2010-11-29 20:49 ` Denis Kenzior
2010-11-27 19:39 ` [PATCH 6/9] gatchat: " Lucas De Marchi
2010-11-29 20:50 ` Denis Kenzior
2010-11-27 19:39 ` [PATCH 7/9] gdbus: " Lucas De Marchi
2010-11-29 20:50 ` Denis Kenzior
2010-12-08 15:35 ` Marcel Holtmann
2010-11-27 19:39 ` [PATCH 8/9] plugins: " Lucas De Marchi
2010-11-29 20:51 ` Denis Kenzior
2010-11-27 19:39 ` [PATCH 9/9] core: " Lucas De Marchi
2010-11-29 20:52 ` Denis Kenzior [this message]
2010-11-29 17:49 ` [PATCH 1/9] coding-style: add rule about checking NULL pointer Denis Kenzior
-- strict thread matches above, loose matches on Subject: below --
2010-11-27 15:38 [PATCH 0/9] coding-style: explicitly compare pointers to NULL Lucas De Marchi
2010-11-27 15:39 ` [PATCH 9/9] core: " Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CF41271.1040504@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox