Open Source Telephony
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] stk: Add busy error for the display text command
Date: Tue, 30 Nov 2010 08:22:50 -0600	[thread overview]
Message-ID: <4CF508BA.8010809@gmail.com> (raw)
In-Reply-To: <9F3EABD6E3419B4C81F34EAABB4D4018813547DA8B@irsmsx501.ger.corp.intel.com>

[-- Attachment #1: Type: text/plain, Size: 908 bytes --]

Hi Guillaume,

On 11/30/2010 07:21 AM, Lucas, GuillaumeX wrote:
> From: Guillaume Lucas <guillaumex.lucas@intel.com>
> 
> According to the sequence 1.2 of the ETSI TS 102 384 a busy
> screen error should be returns for the display text proactive
> command when the ME is not able to display the text.
> ---
>  doc/stk-api.txt |    1 +
>  src/stk.c       |   15 +++++++++++++++
>  src/stkagent.c  |   12 ++++++++++--
>  src/stkagent.h  |    1 +
>  4 files changed, 27 insertions(+), 2 deletions(-)
> 

Patch has been applied, however I fixed one minor booboo for you:

Applying: stk: Add busy error for the display text command
/home/denkenz/ofono-master/.git/rebase-apply/patch:113: trailing whitespace.
			ALLOWED_ERROR_GO_BACK | ALLOWED_ERROR_TERMINATE |
fatal: 1 line adds whitespace errors.
Patch failed at 0001 stk: Add busy error for the display text command

Regards,
-Denis

  reply	other threads:[~2010-11-30 14:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-30 13:21 [PATCH] stk: Add busy error for the display text command Lucas, GuillaumeX
2010-11-30 14:22 ` Denis Kenzior [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-11-25  8:44 Lucas, GuillaumeX
2010-11-29 21:17 ` andrzej zaborowski
2010-11-30  9:15   ` Lucas, GuillaumeX
2010-11-30  9:24     ` Jeevaka.Badrappan
2010-11-30 12:25     ` Denis Kenzior
2010-11-30 12:38       ` Lucas, GuillaumeX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CF508BA.8010809@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox