From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: Need Clarification on DCS handling in Status Report for SMS
Date: Thu, 02 Dec 2010 07:57:58 -0600 [thread overview]
Message-ID: <4CF7A5E6.5080703@gmail.com> (raw)
In-Reply-To: <C681C76E0D5F1E4BB01DE79E0A80EEC702D3A7C0@usrdes03.ebgroup.elektrobit.com>
[-- Attachment #1: Type: text/plain, Size: 1165 bytes --]
Hi Rajesh,
>
> Yes, this is a bug. But rather than setting the DCS to default in
> this case, we should rather not call that sms_dcs_decode() function
> from ofono_sms_status_notify(), as the class information derived from
> the DCS decoding is not used there and also we are not handling the
> optional text information in the status report handling currently.
It is still a bug that should be fixed ;)
>
> If we decide to handle this optional text information (most likely not
> going to happen), then some modifications are required.
>
> Also there is another bug in the current code which might not be
> relevant
> if we decide to remove the sms_dcs_decode() function call from
> ofono_sms_status_notify(). In that function call instead of passing
> s.status_report.dcs, we are currently passing s.deliver.dcs.
That is a good catch. We should actually check the DCS to filter out
any malformed status reports.
Anyway, both issues should now be fixed with commits:
c5a42cfabe3abe0d99299daffbe04c33a217fb25
ac72349017fbfdecbba000c0259cc6b99f0873ed
Please test and report back whether the issues persist.
Regards,
-Denis
next prev parent reply other threads:[~2010-12-02 13:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <C681C76E0D5F1E4BB01DE79E0A80EEC702D3A79D@usrdes03.ebgroup.elektrobit.com>
2010-12-02 2:03 ` Need Clarification on DCS handling in Status Report for SMS Rajesh.Nagaiah
2010-12-02 5:28 ` Sankar
2010-12-02 13:57 ` Denis Kenzior [this message]
2010-12-01 13:55 Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CF7A5E6.5080703@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox