From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 0/5] Call Counters (2nd)
Date: Tue, 07 Dec 2010 12:33:09 -0600 [thread overview]
Message-ID: <4CFE7DE5.4090709@gmail.com> (raw)
In-Reply-To: <AANLkTim07pnimBQFXt8z43ewjPOW9GSobv8yTLJyfGmR@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 997 bytes --]
Hi Aki,
On 12/07/2010 06:57 AM, Aki Niemi wrote:
> Hi Andras,
>
> 2010/11/22 Andras Domokos <Andras.Domokos@nokia.com>:
>> Here a proposal for call counters implementation for keeping track
>> of the total incoming and outgoing call duration counters. Each
>> established call instance is contributing to either of the call
>> duration counters. The 2 counters are updated periodically when
>> there is an established call and the information is stored in
>> a file. The bookkeeping of the call duration counters are per IMSI
>> number.
>> The implementation makes use of the history framework which had to be
>> expanded with a function for marking the beginning of a voice call.
>> There is a D-Bus interface to call counters for reading and clearing
>> the counters.
>
> This set looks good to me, and I believe you fixed the issues from
> previous review comments. Denis, are you ok with this?
>
I'm still catching up, let me take another look.
Regards,
-Denis
next prev parent reply other threads:[~2010-12-07 18:33 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-22 16:25 [PATCH 0/5] Call Counters (2nd) Andras Domokos
2010-11-22 16:25 ` [RFC PATCH 1/5] history: expand history API include file Andras Domokos
2010-11-22 16:26 ` [RFC PATCH 2/5] history: expand history API Andras Domokos
2010-11-22 16:26 ` [RFC PATCH 3/5] voicecall: take into use the new history function Andras Domokos
2010-11-22 16:26 ` [RFC PATCH 4/5] plugins: add call counters Andras Domokos
2010-11-22 16:26 ` [RFC PATCH 5/5] doc: call counters API doc Andras Domokos
2010-12-07 12:57 ` [PATCH 0/5] Call Counters (2nd) Aki Niemi
2010-12-07 18:33 ` Denis Kenzior [this message]
2010-12-08 9:03 ` Marcel Holtmann
2010-12-08 9:34 ` Aki Niemi
2010-12-08 12:41 ` Marcel Holtmann
2010-12-08 13:28 ` Mika.Liljeberg
2010-12-08 16:01 ` Andras Domokos
2010-12-08 16:12 ` Marcel Holtmann
2010-12-08 17:30 ` Andras Domokos
2010-12-08 22:32 ` Marcel Holtmann
2010-12-08 21:02 ` Kai.Vehmanen
2010-12-08 22:35 ` Marcel Holtmann
2010-12-09 12:25 ` Kai.Vehmanen
2010-12-09 18:10 ` Marcel Holtmann
2010-12-09 19:52 ` Kai.Vehmanen
2010-12-09 22:53 ` Marcel Holtmann
2010-12-10 8:14 ` Andras Domokos
2010-12-10 17:57 ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2010-12-10 18:34 ` Marcel Holtmann
2010-12-10 23:57 ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2010-12-11 14:57 ` Marcel Holtmann
2010-12-13 7:56 ` Kai.Vehmanen
2010-12-12 15:46 ` Kai.Vehmanen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CFE7DE5.4090709@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox