From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 1/7] call-forwarding: Read/Write cfis/cphs-cff
Date: Tue, 07 Dec 2010 12:41:37 -0600 [thread overview]
Message-ID: <4CFE7FE1.2000707@gmail.com> (raw)
In-Reply-To: <B668883EB5DD7144ADFC248A72176EA802C40D5C@fioues07.ebgroup.elektrobit.com>
[-- Attachment #1: Type: text/plain, Size: 478 bytes --]
Hi Jeevaka,
On 12/07/2010 07:59 AM, Jeevaka.Badrappan(a)elektrobit.com wrote:
> Hi Denis,
>
>>> + ofono_bool_t online;
>>
>> Why do you need to track this variable? Can't you simply
>> call ofono_modem_get_online()?
>>
>
> This way calling of ofono_modem_get_online for each get or set request
> can be avoided.
>
Sure, but it is doubtful you really need to 'optimize' those cases. The
code is way cleaner without it in my opinion.
Regards,
-Denis
next prev parent reply other threads:[~2010-12-07 18:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 10:37 Read/Write EFcfis/EFcphs-cff Jeevaka Badrappan
2010-11-29 10:37 ` [PATCH 1/7] call-forwarding: Read/Write cfis/cphs-cff Jeevaka Badrappan
2010-12-03 19:08 ` Denis Kenzior
2010-12-07 13:59 ` Jeevaka.Badrappan
2010-12-07 18:41 ` Denis Kenzior [this message]
2010-11-29 10:37 ` [PATCH 2/7] ifx: Move call forwarding to post sim Jeevaka Badrappan
2010-11-29 10:37 ` [PATCH 3/7] isigen: " Jeevaka Badrappan
2010-11-29 10:38 ` [PATCH 4/7] plugins/n900: " Jeevaka Badrappan
2010-11-29 10:38 ` [PATCH 5/7] phonesim: " Jeevaka Badrappan
2010-11-29 10:38 ` [PATCH 6/7] doc: Add new property to call forwarding Jeevaka Badrappan
2010-11-29 10:38 ` [PATCH 7/7] TODO: Marking the Read/Write EFcfis task as done Jeevaka Badrappan
-- strict thread matches above, loose matches on Subject: below --
2010-12-07 20:37 Read/Write EFcfis/EFcphs-cff files Jeevaka Badrappan
2010-12-07 20:37 ` [PATCH 1/7] call-forwarding: Read/Write cfis/cphs-cff Jeevaka Badrappan
2010-12-09 17:43 Read/Write EFcfis/EFcphs-cff files-v3 Jeevaka Badrappan
2010-12-09 17:43 ` [PATCH 1/7] call-forwarding: Read/Write cfis/cphs-cff Jeevaka Badrappan
2010-12-10 18:56 Read/Write EFcfis/EFcphs-cff files-v4 Jeevaka Badrappan
2010-12-10 18:56 ` [PATCH 1/7] call-forwarding: Read/Write cfis/cphs-cff Jeevaka Badrappan
2010-12-17 7:04 ` Jeevaka Badrappan
2010-12-17 23:16 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CFE7FE1.2000707@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox