From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 2/5] cdma-voicecall: Add CDMA MO Call Support
Date: Thu, 09 Dec 2010 02:05:58 -0600 [thread overview]
Message-ID: <4D008DE6.6080200@gmail.com> (raw)
In-Reply-To: <1291748978.3053.23.camel@dardoyle-desktop>
[-- Attachment #1: Type: text/plain, Size: 702 bytes --]
Hi Dara,
>> If not, then using an enum defined in include/cdma-voicecall.h would be
>> better. One major benefit of defining a dedicated enum for CDMA is the
>> compiler checking that all enum values are being handled. If you re-use
>> the GSM version you would have to resort to using default statements.
>> This causes you to lose that extra compiler sanity checking, not to
>> mention is against rule M12 of the coding style. And yes I know we're
>> not always consistent with this one ;)
>>
>
> This is our preference- we can move the cdma enum from /src/common.h
> into include/cdma-voicecall.h if you would prefer that location?
I'm fine with doing that.
Regards,
-Denis
next prev parent reply other threads:[~2010-12-09 8:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 23:31 [PATCH 2/5] cdma-voicecall: Add CDMA MO Call Support Dara Spieker-Doyle
2010-12-03 0:30 ` Rajesh.Nagaiah
2010-12-03 21:20 ` Dara Spieker-Doyle
2010-12-03 21:34 ` Rajesh.Nagaiah
2010-12-07 3:16 ` Denis Kenzior
2010-12-07 19:09 ` Dara Spieker-Doyle
2010-12-09 8:05 ` Denis Kenzior [this message]
2010-12-09 8:36 ` Denis Kenzior
2010-12-10 21:26 ` Dara Spieker-Doyle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D008DE6.6080200@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox