Open Source Telephony
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 4/5] cdmagen: Add CDMA MO Call Support
Date: Thu, 09 Dec 2010 02:46:26 -0600	[thread overview]
Message-ID: <4D009762.5070201@gmail.com> (raw)
In-Reply-To: <1291332685-18740-5-git-send-email-dara.spieker-doyle@nokia.com>

[-- Attachment #1: Type: text/plain, Size: 506 bytes --]

Hi Dara,

On 12/02/2010 05:31 PM, Dara Spieker-Doyle wrote:
> ---
>  Makefile.am         |    3 +
>  plugins/cdmagen.c   |  276 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  plugins/ofono.rules |    4 +

I'd really prefer ofono.rules chunk to be in a separate patch

>  plugins/udev.c      |   21 ++++

And the changes to udev to be in a separate patch as well.

>  4 files changed, 304 insertions(+), 0 deletions(-)
>  create mode 100644 plugins/cdmagen.c
> 

Regards,
-Denis

      reply	other threads:[~2010-12-09  8:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-02 23:31 [PATCH 4/5] cdmagen: Add CDMA MO Call Support Dara Spieker-Doyle
2010-12-09  8:46 ` Denis Kenzior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D009762.5070201@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox