Open Source Telephony
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] stkutil: fix crash issue cause by null length of text string
Date: Fri, 10 Dec 2010 10:48:14 -0600	[thread overview]
Message-ID: <4D0259CE.1000804@gmail.com> (raw)
In-Reply-To: <9F3EABD6E3419B4C81F34EAABB4D40188136D95B11@irsmsx501.ger.corp.intel.com>

[-- Attachment #1: Type: text/plain, Size: 505 bytes --]

Hi Guillaume,

On 12/07/2010 04:58 AM, Lucas, GuillaumeX wrote:
> From: Guillaume Lucas <guillaumex.lucas@intel.com>
> 
> According to 3GPP TS 31.124 a null length for the text string
> should be allowed. An empty string must be returned to the
> user in this case.
> ---
>  src/stkutil.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 

Patch has been applied, but please re-run the unit tests when you change
stkutil.  You actually broke a few ;)

Regards,
-Denis

      parent reply	other threads:[~2010-12-10 16:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-07 10:58 [PATCH] stkutil: fix crash issue cause by null length of text string Lucas, GuillaumeX
2010-12-07 20:25 ` Andrzej Zaborowski
2010-12-07 21:55 ` Jeevaka.Badrappan
2010-12-07 22:33   ` Andrzej Zaborowski
2010-12-08  8:37     ` Lucas, GuillaumeX
2010-12-10 16:48 ` Denis Kenzior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D0259CE.1000804@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox