From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] smsutil: do not hardcode TP-ValidityPeriod
Date: Thu, 16 Dec 2010 18:55:12 -0600 [thread overview]
Message-ID: <4D0AB4F0.1040801@gmail.com> (raw)
In-Reply-To: <1291845421-1898-1-git-send-email-Pekka.Pessi@nokia.com>
[-- Attachment #1: Type: text/plain, Size: 810 bytes --]
Hi Pekka,
On 12/08/2010 03:57 PM, Pekka.Pessi(a)nokia.com wrote:
> From: Pekka Pessi <Pekka.Pessi@nokia.com>
>
> ---
> src/smsutil.c | 6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/src/smsutil.c b/src/smsutil.c
> index f4eee24..59faaf7 100644
> --- a/src/smsutil.c
> +++ b/src/smsutil.c
> @@ -3162,11 +3162,10 @@ GSList *sms_datagram_prepare(const char *to,
> memset(&template, 0, sizeof(struct sms));
> template.type = SMS_TYPE_SUBMIT;
> template.submit.rd = FALSE;
> - template.submit.vpf = SMS_VALIDITY_PERIOD_FORMAT_RELATIVE;
> + template.submit.vpf = SMS_VALIDITY_PERIOD_FORMAT_ABSENT;
Can I get a bit more of an explanation from you as to why the 'absent'
validity period is better than hardcoding this to 24 hours?
Regards,
-Denis
next prev parent reply other threads:[~2010-12-17 0:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-08 21:57 [PATCH] smsutil: do not hardcode TP-ValidityPeriod Pekka.Pessi
2010-12-17 0:55 ` Denis Kenzior [this message]
2010-12-17 13:29 ` Pekka Pessi
2010-12-17 15:22 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D0AB4F0.1040801@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox