Re: [PATCH v2] ifx: Adding modem selftest to Infineon modem

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 872 bytes --]

Hi Waldo,

On 12/18/2010 01:58 PM, Bastian, Waldo wrote:
>>> @@ -80,6 +82,18 @@ static const char *dlc_nodes[NUM_DLC] = { "/dev/ttyGSM1", "/dev/ttyGSM2",
>>>  
>>>  static const char *none_prefix[] = { NULL };
>>>  static const char *xdrv_prefix[] = { "+XDRV:", NULL };
>>> +static const char *empty_prefix[] = { "", NULL };
>>
>> This is still wrong. See my comment from the original email. I am not
>> sure you really know what { "", NULL } means.
> 
> The response doesn't really have a proper prefix (see example below), this way the entire response ends up in the callback. Is there a better way? Given that there aren't any URC registered yet, it will not interfere with any other response. It's obviously not a good idea to use it once the modem is powered up.
> 

Then simply passing NULL instead of empty_prefix is sufficient.

Regards,
-Denis