From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 3/5] cdma-atmodem: Add CDMA SMS Support
Date: Mon, 20 Dec 2010 14:39:38 -0600 [thread overview]
Message-ID: <4D0FBF0A.1080100@gmail.com> (raw)
In-Reply-To: <1291854951-2378-4-git-send-email-lei.2.yu@nokia.com>
[-- Attachment #1: Type: text/plain, Size: 864 bytes --]
On 12/08/2010 06:35 PM, Lei Yu wrote:
> ---
> Makefile.am | 7 ++
> configure.ac | 5 ++
> drivers/cdma-atmodem/atmodem.c | 47 ++++++++++++
> drivers/cdma-atmodem/atmodem.h | 23 ++++++
You need to synchronize with Dara on this one. Both of you are sending
the same stub implementation. I suggest submitting this as a separate
patch. And please name it cdmamodem/cdmamodem.c & .h. Dara has this
right actually.
> drivers/cdma-atmodem/atutil.c | 45 ++++++++++++
> drivers/cdma-atmodem/atutil.h | 64 +++++++++++++++++
As I mentioned before, please use the atutil.[ch] from atmodem directly.
No need to create a new set of these...
> drivers/cdma-atmodem/sms.c | 151 ++++++++++++++++++++++++++++++++++++++++
And this one should be in a separate patch ;)
Regards,
-Denis
next prev parent reply other threads:[~2010-12-20 20:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-09 0:35 [PATCH 3/5] cdma-atmodem: Add CDMA SMS Support Lei Yu
2010-12-20 20:39 ` Denis Kenzior [this message]
2010-12-20 21:31 ` Lei Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D0FBF0A.1080100@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox