Open Source Telephony
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 2/2] fake a sim-inserted status
Date: Mon, 20 Dec 2010 15:31:07 -0600	[thread overview]
Message-ID: <4D0FCB1B.50808@gmail.com> (raw)
In-Reply-To: <1292005692-19615-1-git-send-email-fgau@pyneo.org>

[-- Attachment #1: Type: text/plain, Size: 1122 bytes --]

Hi,

On 12/10/2010 12:28 PM, F. Gau wrote:
> From: M. Dietrich <mdt@emdete.de>
> 
> 	while the sim detection does not work this patch at least allows to use
> 	those modems. until someone has the time to work out a correct solution
> 	this is a usefull workaround.
> ---
>  plugins/huawei.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/plugins/huawei.c b/plugins/huawei.c
> index 25dfaca..df506d3 100644
> --- a/plugins/huawei.c
> +++ b/plugins/huawei.c
> @@ -586,6 +586,7 @@ static void huawei_pre_sim(struct ofono_modem *modem)
>  	ofono_devinfo_create(modem, 0, "atmodem", data->pcui);
>  	data->sim = ofono_sim_create(modem, OFONO_VENDOR_QUALCOMM_MSM,
>  					"atmodem", data->pcui);
> +	ofono_sim_inserted_notify(data->sim, TRUE);
>  
>  	data->sim_poll_count = 0;
>  	query_sim_state(modem);

I don't want to completely bypass the sim inserted logic (which seems to
work on other Huawei models) for the sake of EM770.

So I really prefer that we do this a bit smarter.  Even simple model to
behavior matching would be acceptable...

Regards,
-Denis

      reply	other threads:[~2010-12-20 21:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-10 18:28 [PATCH 2/2] fake a sim-inserted status F. Gau
2010-12-20 21:31 ` Denis Kenzior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D0FCB1B.50808@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox