Open Source Telephony
 help / color / mirror / Atom feed
From: Dara Spieker-Doyle <dara.spieker-doyle@nokia.com>
To: ofono@ofono.org
Subject: Re: [PATCH v2 4/9] cdma-voicecall: Add CDMA MO Call Support
Date: Mon, 20 Dec 2010 13:47:43 -0800	[thread overview]
Message-ID: <4D0FCEFF.2090607@nokia.com> (raw)
In-Reply-To: <4D0FC43D.6070503@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 540 bytes --]

Hi Denis

On 12/20/2010 01:01 PM, ext Denis Kenzior wrote:

>> +
>> +static const char *voicecall_build_path(struct ofono_cdma_voicecall_manager *vc)
>> +{
>> +     static char path[256];
>> +
>> +     snprintf(path, sizeof(path), "%s/voicecall",
>> +                     __ofono_atom_get_path(vc->atom));
>
> I'm still confused what this is for?  The CDMA voicecall proposal does
> not have leaf objects...
Sorry yes, this is the same oversight as before. I will fix this and 
remove these path references.

Thanks
Dara

      reply	other threads:[~2010-12-20 21:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-17 23:11 [PATCH v2 4/9] cdma-voicecall: Add CDMA MO Call Support Dara Spieker-Doyle
2010-12-20 21:01 ` Denis Kenzior
2010-12-20 21:47   ` Dara Spieker-Doyle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D0FCEFF.2090607@nokia.com \
    --to=dara.spieker-doyle@nokia.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox