From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH v2 3/9] cdma-voicecall: Add CDMA MO Call Support
Date: Mon, 20 Dec 2010 15:48:16 -0600 [thread overview]
Message-ID: <4D0FCF20.5050806@gmail.com> (raw)
In-Reply-To: <4D0FCEF0.8000501@nokia.com>
[-- Attachment #1: Type: text/plain, Size: 656 bytes --]
Hi Dara,
>>> +
>>> +struct ofono_cdma_voicecall_manager;
>>
>> Please call this ofono_cdma_voicecall.
> This is actually our preference as well as there is no multicall in
> CDMA, just the single voicecall. To that end, does it not make sense to
> also rename the interface "Voicecall" rather than "VoiceCallManager"?
This comment was based mostly on the naming of the current gsm voicecall
atom (e.g. ofono_voicecall, not ofono_voicecall_manager)
For the interface name I suggest we stick to .cdma.VoiceCallManager for
now to be consistent with the GSM naming. However, I'm open to changing
this one in the future.
Regards,
-Denis
prev parent reply other threads:[~2010-12-20 21:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-17 23:11 [PATCH v2 3/9] cdma-voicecall: Add CDMA MO Call Support Dara Spieker-Doyle
2010-12-20 20:50 ` Denis Kenzior
2010-12-20 21:47 ` Dara Spieker-Doyle
2010-12-20 21:48 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D0FCF20.5050806@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox