From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 4/5] cdmaphonesim: Add CDMA SMS Support
Date: Mon, 20 Dec 2010 16:32:15 -0600 [thread overview]
Message-ID: <4D0FD96F.1090400@gmail.com> (raw)
In-Reply-To: <4D0FD043.90003@nokia.com>
[-- Attachment #1: Type: text/plain, Size: 1298 bytes --]
Hi Lei,
>>
>> Have you considered adding a CDMA/GSM selector to phonesim.conf instead?
>> So e.g. a new configuration key called 'Type' where type can be 'gsm'
>> or 'cdma'.
>>
>> That way you can share much of the phonesim plugin plumbing and only
>> populate the atoms differently...
>>
>
> We thought about this briefly but decided not pursuing that path at this
> stage of CDMA development mainly due to following reasons: a). We think
> it may make more sense to let CDMA development evolving a bit more on
> its own and then evaluate to see for which part it makes sense
> to merge. We are afraid merging too early will make the phonesim.c code
> looking ugly with a lot of if/else down the road. We are planning to
> evaluate things like this when we have at least a few CDMA atoms
> implemented. b). We definitely would like to cause as little disruption
> to GSM as possible at this stage of CDMA development.
Ok I'm still waffling on this one but I can accept a temporary cdma
phonesim plugin for now.
Can you make sure to strip it down some more? For instance you can omit
Multiplexer and Modem configure key handling.
And having a separate configure option for cdma phonesim seems unneeded.
Lump this one with --enable-phonesim.
Regards,
-Denis
next prev parent reply other threads:[~2010-12-20 22:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-09 0:35 [PATCH 4/5] cdmaphonesim: Add CDMA SMS Support Lei Yu
2010-12-20 20:42 ` Denis Kenzior
2010-12-20 21:53 ` Lei Yu
2010-12-20 22:32 ` Denis Kenzior [this message]
2010-12-20 23:14 ` Lei Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D0FD96F.1090400@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox