Open Source Telephony
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 1/5] simfs: Cache flushing functions.
Date: Wed, 22 Dec 2010 20:57:49 -0600	[thread overview]
Message-ID: <4D12BAAD.1000505@gmail.com> (raw)
In-Reply-To: <1291989564-28694-1-git-send-email-andrew.zaborowski@intel.com>

[-- Attachment #1: Type: text/plain, Size: 658 bytes --]

Hi Andrew,

<snip>

> diff --git a/src/simfs.h b/src/simfs.h
> index ef962db..ace25bf 100644
> --- a/src/simfs.h
> +++ b/src/simfs.h
> @@ -47,4 +47,6 @@ char *sim_fs_get_cached_image(struct sim_fs *fs, int id);
>  
>  void sim_fs_cache_image(struct sim_fs *fs, const char *image, int id);
>  
> +void sim_fs_cache_flush(struct sim_fs *fs, int id);
> +
>  void sim_fs_free(struct sim_fs *fs);

So as I mentioned on IRC I think you have the right idea.  However, I'd
prefer that we separate the three types of flushes:

- Full simfs flush
- specific ef cache flush
- specific icon cache flush
- full icon cache flush

Regards,
-Denis

      parent reply	other threads:[~2010-12-23  2:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-10 13:59 [PATCH 1/5] simfs: Cache flushing functions Andrzej Zaborowski
2010-12-10 13:59 ` [PATCH 2/5][RfC] Add SIM filesystem watch api Andrzej Zaborowski
2010-12-10 13:59 ` [PATCH 3/5][RfC] sim: Implement file watching and basic refresh Andrzej Zaborowski
2010-12-10 13:59 ` [PATCH 4/5][RfC] sim: Watch files we keep in memory Andrzej Zaborowski
2010-12-10 13:59 ` [PATCH 5/5][RfC] stk: Partially handle Refresh command Andrzej Zaborowski
2010-12-23  2:57 ` Denis Kenzior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D12BAAD.1000505@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox