Open Source Telephony
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: unsolicited multiline result
Date: Thu, 30 Dec 2010 11:03:16 -0600	[thread overview]
Message-ID: <4D1CBB54.8040103@gmail.com> (raw)
In-Reply-To: <1293728155-1781-1-git-send-email-petteri.tikander@ixonos.com>

[-- Attachment #1: Type: text/plain, Size: 888 bytes --]

Hi Petteri,

On 12/30/2010 10:55 AM, Petteri Tikander wrote:
> 
> This patch is for handling multiline unsolicited result-codes.
> So state-machine used for handling result-bytes (gsmv1_feed) is set to the multiline-response
> state. Otherwise next lines from the result-buffer are not handled correctly,
> and response-handling will get stuck.

I've never heard of multiline-unsolicited result codes.  Unsolicited
responses are always prefixed and suffixed by a crlf.  Are you trying to
combine the +CEN query and +CEN unsolicited responses into a single
parser by any chance?

> 
> In the other hand, this correction keeps result-handling still unchanged.
> So single line is notified to the upper level (atoms) at a time, not all lines of the result.
> For instance: network-emergency numbers cannot be collect to the one single notification yet.

Regards,
-Denis

  parent reply	other threads:[~2010-12-30 17:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-30 16:55 unsolicited multiline result Petteri Tikander
2010-12-30 16:55 ` [RFC PATCH] gatchat: support for " Petteri Tikander
2010-12-30 17:03 ` Denis Kenzior [this message]
2010-12-30 17:52   ` Tikander Petteri
2010-12-30 18:51     ` Denis Kenzior
2010-12-31 17:07       ` Tikander Petteri
2011-01-14 18:33         ` Tikander Petteri
2011-01-14 20:22           ` Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D1CBB54.8040103@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox