From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH v2 2/4] sim: query remaining pin retries
Date: Tue, 04 Jan 2011 11:13:51 -0600 [thread overview]
Message-ID: <4D23554F.2040604@gmail.com> (raw)
In-Reply-To: <1294146379-30854-3-git-send-email-lucas.demarchi@profusion.mobi>
[-- Attachment #1: Type: text/plain, Size: 810 bytes --]
Hi Lucas,
On 01/04/2011 07:06 AM, Lucas De Marchi wrote:
> Check the remaining pin retries after each operation that might have
> changed it, i.e. locking, unlocking, reseting or changing pin.
> ---
> src/sim.c | 102 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 102 insertions(+), 0 deletions(-)
>
> diff --git a/src/sim.c b/src/sim.c
> index 335f611..a57fe84 100644
> --- a/src/sim.c
> +++ b/src/sim.c
> @@ -62,6 +62,8 @@ struct ofono_sim {
> enum ofono_sim_password_type pin_type;
> gboolean locked_pins[OFONO_SIM_PASSWORD_SIM_PUK]; /* Number of PINs */
>
> + GSList *pin_retries;
> +
Are you forgetting to free the pin_retries array when the sim is removed
or the sim atom is destroyed?
The rest seems fine to me.
Regards,
-Denis
next prev parent reply other threads:[~2011-01-04 17:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 13:06 [PATCH v2 0/4] Query retry counters Lucas De Marchi
2011-01-04 13:06 ` [PATCH v2 1/4] include: add method to query pin Retries Lucas De Marchi
2011-01-04 17:11 ` Denis Kenzior
2011-01-04 13:06 ` [PATCH v2 2/4] sim: query remaining pin retries Lucas De Marchi
2011-01-04 17:13 ` Denis Kenzior [this message]
2011-01-04 17:26 ` Lucas De Marchi
2011-01-04 17:29 ` Denis Kenzior
2011-01-04 13:06 ` [PATCH v2 3/4] doc: detail Retries property Lucas De Marchi
2011-01-04 13:06 ` [PATCH v2 4/4] atmodem: implement query for remaining pin retries Lucas De Marchi
2011-01-04 13:20 ` [PATCH v2 0/4] Query retry counters Sankar
2011-01-04 14:24 ` Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D23554F.2040604@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox