From: Lei Yu <lei.2.yu@nokia.com>
To: ofono@ofono.org
Subject: Re: [PATCH v3 2/7] cdma-sms: Add CDMA SMS Support
Date: Thu, 06 Jan 2011 08:58:37 -0800 [thread overview]
Message-ID: <4D25F4BD.9010200@nokia.com> (raw)
In-Reply-To: <C681C76E0D5F1E4BB01DE79E0A80EEC702E6576B@usrdes03.ebgroup.elektrobit.com>
[-- Attachment #1: Type: text/plain, Size: 652 bytes --]
Hi Rajesh,
On 01/05/2011 11:17 AM, ext Rajesh.Nagaiah(a)elektrobit.com wrote:
> Hi Lei,
>
>> +void ofono_cdma_sms_deliver_notify(struct ofono_cdma_sms *cdma_sms,
>> + unsigned char *pdu, int
> tpdu_len);
>
> As there is no SC number in CDMA, the whole PDU is the actual TPDU as
> well.
> So either we should call pdu/pdu_len or tpdu/tpdu_len. Having
> pdu/tpdu_len
> might be mistaken.
>
Will change to tpdu/tpdu_len per CDMA SMS spec for transport layer.
> BR,
> Rajesh
> _______________________________________________
> ofono mailing list
> ofono(a)ofono.org
> http://lists.ofono.org/listinfo/ofono
Regards,
Lei
prev parent reply other threads:[~2011-01-06 16:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 23:00 [PATCH v3 2/7] cdma-sms: Add CDMA SMS Support Lei Yu
2011-01-04 23:06 ` Denis Kenzior
2011-01-05 16:22 ` Lei Yu
2011-01-05 16:38 ` Denis Kenzior
2011-01-05 19:17 ` Rajesh.Nagaiah
2011-01-06 16:58 ` Lei Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D25F4BD.9010200@nokia.com \
--to=lei.2.yu@nokia.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox