Re: [PATCH v3 0/6] Query retry counters

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1297 bytes --]

Hi Lucas,

On 01/10/2011 03:02 PM, Lucas De Marchi wrote:
> Diff from previous version:
>  - memset(retries, -1, sizeof(retries)) works, but it's just because of luck in
>    2's complement logic. Use a loop instead.
>  - "^CPIN" command is exclusive to HUAWEI. So change "xcpin" prefix to
>    "huawei_cpin" and passs OFONO_VENDOR_HUAWEI quirk on sim creation. This change
>    needed 2 more patches (the first ones) in order to make it work.
>  - space cleanup
>  - use memcmp to compare the pin_retries array instead of a loop
> 
> Lucas De Marchi (6):
>   atmodem: check for VENDOR_HUAWEI on sim atom
>   huawei: use VENDOR_HUAWEI quirk on sim creation
>   include: add method to query pin Retries
>   sim: query remaining pin retries
>   doc: detail Retries property
>   atmodem: implement query for remaining pin retries
> 
>  doc/sim-api.txt       |   12 ++++++
>  drivers/atmodem/sim.c |   95 ++++++++++++++++++++++++++++++++++++++++++++++++-
>  include/sim.h         |    5 +++
>  plugins/huawei.c      |    2 +-
>  src/sim.c             |   90 ++++++++++++++++++++++++++++++++++++++++++++++
>  5 files changed, 202 insertions(+), 2 deletions(-)
> 

I have applied the first 5 patches in this series.  See my comments for
the last patch.

Regards,
-Denis