From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [RFC PATCH 3/4] sim: add ofono_sim_get_mnc_length
Date: Tue, 11 Jan 2011 09:03:12 -0600 [thread overview]
Message-ID: <4D2C7130.5050101@gmail.com> (raw)
In-Reply-To: <1294706442.3873.9.camel@aeonflux>
[-- Attachment #1: Type: text/plain, Size: 926 bytes --]
Hi Marcel,
On 01/10/2011 06:40 PM, Marcel Holtmann wrote:
> Hi Jukka,
>
>> include/sim.h | 1 +
>> src/sim.c | 8 ++++++++
>> 2 files changed, 9 insertions(+), 0 deletions(-)
>>
>> diff --git a/include/sim.h b/include/sim.h
>> index 7860e24..9b21f2e 100644
>> --- a/include/sim.h
>> +++ b/include/sim.h
>> @@ -173,6 +173,7 @@ void ofono_sim_set_data(struct ofono_sim *sim, void *data);
>> void *ofono_sim_get_data(struct ofono_sim *sim);
>>
>> const char *ofono_sim_get_imsi(struct ofono_sim *sim);
>> +unsigned int ofono_sim_get_mnc_length(struct ofono_sim *sim);
>
> so here is now the question. Do we wanna make this simple and do it like
> this or just provide functions to the MCC and MNC like we do inside the
> network registration interface?
>
> Denis, any favorites?
>
From an API point of view providing the mnc and mcc directly is a better
idea.
Regards,
-Denis
next prev parent reply other threads:[~2011-01-11 15:03 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-10 13:11 [RFC PATCHv3 0/4] Plugin API for provisioning of GPRS context settings Jukka Saunamaki
2011-01-10 13:11 ` [RFC PATCH 1/4] Added GPRS context provisioning driver API sources Jukka Saunamaki
2011-01-12 6:43 ` Marcel Holtmann
2011-01-12 16:43 ` Denis Kenzior
2011-01-10 13:11 ` [RFC PATCH 2/4] gprs: add automatic context settings provisioning Jukka Saunamaki
2011-01-12 6:51 ` Marcel Holtmann
2011-01-12 7:26 ` Jukka Saunamaki
2011-01-12 16:37 ` Marcel Holtmann
2011-01-10 13:11 ` [RFC PATCH 3/4] sim: add ofono_sim_get_mnc_length Jukka Saunamaki
2011-01-11 0:40 ` Marcel Holtmann
2011-01-11 15:03 ` Denis Kenzior [this message]
2011-01-10 13:11 ` [RFC PATCH 4/4] Dummy example GPRS context provisioning driver Jukka Saunamaki
2011-01-12 6:48 ` Marcel Holtmann
2011-01-12 7:41 ` Jukka Saunamaki
2011-01-12 16:46 ` Denis Kenzior
2011-01-13 6:36 ` Jukka Saunamaki
2011-01-13 15:57 ` Denis Kenzior
2011-01-14 6:53 ` Jukka Saunamaki
2011-01-14 7:47 ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2011-01-14 10:37 ` Marcel Holtmann
2011-01-14 10:46 ` Jukka Saunamaki
2011-01-14 13:44 ` Marcel Holtmann
2011-01-14 13:58 ` Jukka Saunamaki
2011-01-14 14:10 ` Marcel Holtmann
2011-01-14 14:42 ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2011-01-15 1:30 ` Marcel Holtmann
2011-01-17 6:20 ` Jukka Saunamaki
2011-01-14 15:07 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2C7130.5050101@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox