From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 2/3] cdmamodem: Add CDMA devinfo support
Date: Thu, 13 Jan 2011 00:03:45 -0600 [thread overview]
Message-ID: <4D2E95C1.40209@gmail.com> (raw)
In-Reply-To: <1294782301-8592-3-git-send-email-dara.spieker-doyle@nokia.com>
[-- Attachment #1: Type: text/plain, Size: 1354 bytes --]
Hi Dara,
On 01/11/2011 03:45 PM, Dara Spieker-Doyle wrote:
> ---
> Makefile.am | 3 +-
> drivers/cdmamodem/cdmamodem.c | 2 +
> drivers/cdmamodem/cdmamodem.h | 2 +
> drivers/cdmamodem/devinfo.c | 169 +++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 175 insertions(+), 1 deletions(-)
> create mode 100644 drivers/cdmamodem/devinfo.c
>
Can you please rebase and resubmit this patch? Further comments below:
> diff --git a/drivers/cdmamodem/cdmamodem.h b/drivers/cdmamodem/cdmamodem.h
> index a5991cf..ef4fad3 100644
> --- a/drivers/cdmamodem/cdmamodem.h
> +++ b/drivers/cdmamodem/cdmamodem.h
> @@ -23,3 +23,5 @@
>
> extern void cdma_at_voicecall_init();
> extern void cdma_at_voicecall_exit();
> +extern void cdma_at_devinfo_init();
> +extern void cdma_at_devinfo_exit();
Please name this cdma_devinfo_init/exit
<snip>
> +static struct ofono_devinfo_driver driver = {
> + .name = "cdmamodem",
> + .probe = cdma_at_devinfo_probe,
> + .remove = cdma_at_devinfo_remove,
> + .query_manufacturer = cdma_at_query_manufacturer,
> + .query_model = cdma_at_query_model,
> + .query_revision = cdma_at_query_revision,
> + .query_serial = cdma_at_query_serial
Please drop the 'at' from these. Use cdma_devinfo_probe, etc.
> +};
> +
Regards,
-Denis
next prev parent reply other threads:[~2011-01-13 6:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-11 21:45 [PATCH 2/3] cdmamodem: Add CDMA devinfo support Dara Spieker-Doyle
2011-01-13 6:03 ` Denis Kenzior [this message]
2011-01-13 18:20 ` Dara Spieker-Doyle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2E95C1.40209@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox