From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH v2 3/9] gps: add public header
Date: Thu, 13 Jan 2011 11:33:22 -0600 [thread overview]
Message-ID: <4D2F3762.3030604@gmail.com> (raw)
In-Reply-To: <1294716238-21218-4-git-send-email-rafael.zurita@profusion.mobi>
[-- Attachment #1: Type: text/plain, Size: 1038 bytes --]
Hi Rafael,
> +
> +#include <ofono/types.h>
> +
> +struct ofono_gps;
> +
> +enum ofono_gps_device_type {
> + OFONO_GPS_DEVICE_TYPE_NMEA = 0,
> +};
> +
> +typedef void (*ofono_gps_enable_cb_t)(const struct ofono_error *error,
> + enum ofono_gps_device_type type,
> + const char *device,
> + void *data);
This function's signature would be modified to receive an int fd instead
of type and device.
> +typedef void (*ofono_gps_disable_cb_t)(const struct ofono_error *error,
> + void *data);
> +
> +struct ofono_gps_driver {
> + const char *name;
This structure should contain enum ofono_gps_device_type type member.
> + int (*probe)(struct ofono_gps *gps, unsigned int vendor, void *data);
> + void (*remove)(struct ofono_gps *gps);
> + void (*enable)(struct ofono_gps *gps,
> + ofono_gps_enable_cb_t cb, void *data);
> + void (*disable)(struct ofono_gps *gps,
> + ofono_gps_disable_cb_t cb, void *data);
> +};
> +
The rest is left more or less as is.
Regards,
-Denis
next prev parent reply other threads:[~2011-01-13 17:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-11 3:23 [PATCH v2 0/9] Add GPS atom Rafael Ignacio Zurita
2011-01-11 3:23 ` [PATCH v2 1/9] gps: define new dbus interface Rafael Ignacio Zurita
2011-01-13 17:11 ` Denis Kenzior
2011-01-11 3:23 ` [PATCH v2 2/9] gps: add new interface to feature map Rafael Ignacio Zurita
2011-01-13 17:11 ` Denis Kenzior
2011-01-11 3:23 ` [PATCH v2 3/9] gps: add public header Rafael Ignacio Zurita
2011-01-13 17:33 ` Denis Kenzior [this message]
2011-01-11 3:23 ` [PATCH v2 4/9] gps: implement interface/atom Rafael Ignacio Zurita
2011-01-11 3:23 ` [PATCH v2 5/9] mbmmodem: add gps atom Rafael Ignacio Zurita
2011-01-11 3:23 ` [PATCH v2 6/9] plugins: add gps atom to mbm Rafael Ignacio Zurita
2011-01-11 3:23 ` [PATCH v2 7/9] plugins/udev.c: add gps comparison for add_mbm registered modem Rafael Ignacio Zurita
2011-01-11 3:23 ` [PATCH v2 8/9] gps: add test scripts Rafael Ignacio Zurita
2011-01-11 3:23 ` [PATCH v2 9/9] gps: add documentation Rafael Ignacio Zurita
2011-01-13 17:30 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2F3762.3030604@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox