From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [offline-atoms PATCH 1/2] Make gprs atom offline-safe.
Date: Wed, 19 Jan 2011 10:57:12 -0600 [thread overview]
Message-ID: <4D3717E8.3050103@gmail.com> (raw)
In-Reply-To: <AANLkTing29eqccHn1Y5_V1g=BELX0HJKMa3_MYD9SaW4@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 731 bytes --]
Hi Pekka,
On 01/19/2011 07:33 AM, Pekka Pessi wrote:
> Hi Denis,
>
> 2011/1/19 Denis Kenzior <denkenz@gmail.com>:
>>> + if (gprs->netreg == NULL) {
>>> + gprs_netreg_removed(gprs);
>>> + return;
>>> + }
>>> +
>>
>> I'm having trouble visualizing why this chunk is necessary. We reset
>> netreg to NULL only when shutting down the atom or when netreg atom goes
>> away. So this condition should never be triggered.
>
> It is for the case where the gprs atom is inserted in post_sim but
> netreg in post_online.
>
I still don't see it, applying your patch and removing this chunk works
just fine. I can set Powered / Roaming Allowed with no issues...
Regards,
-Denis
prev parent reply other threads:[~2011-01-19 16:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-14 14:40 [offline-atoms PATCH 0/2] Pekka.Pessi
2011-01-14 14:40 ` [offline-atoms PATCH 1/2] Make gprs atom offline-safe Pekka.Pessi
2011-01-14 14:40 ` [offline-atoms PATCH 2/2] Make sms " Pekka.Pessi
2011-01-19 4:10 ` Denis Kenzior
2011-01-19 4:04 ` [offline-atoms PATCH 1/2] Make gprs " Denis Kenzior
2011-01-19 13:33 ` Pekka Pessi
2011-01-19 16:57 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D3717E8.3050103@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox