From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 1/6] netreg: Deprecate the deregister method
Date: Thu, 20 Jan 2011 09:57:52 -0600 [thread overview]
Message-ID: <4D385B80.2010304@gmail.com> (raw)
In-Reply-To: <1295474035-7142-2-git-send-email-aki.niemi@nokia.com>
[-- Attachment #1: Type: text/plain, Size: 749 bytes --]
Hi Aki,
> @@ -1795,14 +1768,8 @@ static void netreg_load_settings(struct ofono_netreg *netreg)
>
> netreg->imsi = g_strdup(imsi);
>
> - mode = g_key_file_get_integer(netreg->settings, SETTINGS_GROUP,
> - "Mode", NULL);
> -
> - if (mode >= 0 && mode <= 2)
> - netreg->mode = mode;
> -
> - g_key_file_set_integer(netreg->settings, SETTINGS_GROUP,
> - "Mode", netreg->mode);
> + netreg->mode = g_key_file_get_integer(netreg->settings, SETTINGS_GROUP,
> + "Mode", NULL);
> }
>
I dropped this chunk and amended your patch to stipulate mode 0 and 1
only. This was a sanity check that no-one is messing with our settings
file.
> void ofono_netreg_register(struct ofono_netreg *netreg)
Regards,
-Denis
next prev parent reply other threads:[~2011-01-20 15:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 21:53 [PATCH 0/6] Deprecate the Deregister() method Aki Niemi
2011-01-19 21:53 ` [PATCH 1/6] netreg: Deprecate the deregister method Aki Niemi
2011-01-20 15:57 ` Denis Kenzior [this message]
2011-01-19 21:53 ` [PATCH 2/6] isimodem: Remove deregister implementation Aki Niemi
2011-01-19 21:53 ` [PATCH 3/6] atmodem: " Aki Niemi
2011-01-19 21:53 ` [PATCH 4/6] api: Remove deregister from modem driver API Aki Niemi
2011-01-19 21:53 ` [PATCH 5/6] doc: Remove deregister method documentation Aki Niemi
2011-01-19 21:53 ` [PATCH 6/6] test: Remove deregister support from test script Aki Niemi
2011-01-20 15:58 ` [PATCH 0/6] Deprecate the Deregister() method Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D385B80.2010304@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox